Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor spelling & grammatical fixes #4444

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Minor spelling & grammatical fixes #4444

merged 3 commits into from
Mar 13, 2024

Conversation

cochcoder
Copy link
Contributor

@cochcoder cochcoder commented Mar 12, 2024 •
edited
Loading

Closes #4441, #4447

SoftFever
SoftFever approved these changes Mar 13, 2024
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
Appreciate your help
We will need to update the corresponding locale files too otherwise we will invalidate those translations.
I'm not able to push changes to PR, so I will merge this PR then push a separate commit

@SoftFever SoftFever merged commit 334f7cf into SoftFever:main Mar 13, 2024
8 of 12 checks passed
SoftFever added a commit that referenced this pull request Mar 13, 2024
@SoftFever
Handle parameter name change properly.
cab5fe7 
Fix build break and keep compatibility to existing user preset after #4444 changes
@cochcoder cochcoder deleted the patch-1 branch March 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mispell
2 participants
@cochcoder @SoftFever