Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ensure vertical feature's UX #4402

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Conversation

SoftFever
Copy link
Owner

@SoftFever SoftFever commented Mar 10, 2024

The previous user experience was somewhat confusing, particularly with the settings for ensure_vertical_shell_thickness and reduce_wall_solid_infill.

This PR improves the UI and refines the functionality of these options:

  1. Changed ensure_vertical_shell_thickness to an enum value type to simplify selection and improve clarity.
  2. Introduced an option to completely disable this feature, giving users more control over their printing preferences.
    vertical

@igiannakas FYI. The 'Critical Only" is same as this combination you added in this PR #3235.
image

@SoftFever SoftFever changed the title Change ensure_vertical_shell_thickness to enum value type. Allow user… Optimize ensure vertical feature's UX Mar 10, 2024
@igiannakas
Copy link
Contributor

Excellent refactor, makes so much more sense now!

is the none a desired option though? This will break vertical slopes, so needs to be used carefully I suppose? Also I think this impacts top surfaces even if not sloped? Haven’t run the build yet so apologies if it doesn’t :)

Maybe the tool tip needs to say that it’s not suitable for any models with sloped surfaces?

@SoftFever
Copy link
Owner Author

SoftFever commented Mar 10, 2024

Excellent refactor, makes so much more sense now!

is the none a desired option though? This will break vertical slopes, so needs to be used carefully I suppose? Also I think this impacts top surfaces even if not sloped? Haven’t run the build yet so apologies if it doesn’t :)

Maybe the tool tip needs to say that it’s not suitable for any models with sloped surfaces?

The use case of "None" that I can think of is for SpeedBenchy or people only want to verify a design as quick as possible

Updating warn user in the tooltip is a good idea. Let me add one

@igiannakas
Copy link
Contributor

Awesome 👏🏻👌🏻

@SoftFever SoftFever merged commit 879c392 into main Mar 10, 2024
8 of 12 checks passed
@SoftFever
Copy link
Owner Author

Merged.

@SoftFever SoftFever deleted the feature/optimize_ensure_vertical branch March 10, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants