Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell type to STEP importer, to fix importing of some STEP files #4247

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

scottmudge
Copy link
Contributor

I had a couple STEP files that were not importing for whatever reason. After throwing OrcaSlicer in a debugger, I noticed the shape_type of the imported object was a 'shell', which should still work for STEP->STL/mesh conversion.

I added the TopAbs_SHELL type to getNamedSolids(...), and indeed it imported fine. Not sure why this shape type was not added to begin with, but adding it seemed to improve support for a variety of STEP files.

I've attached an example of a file that would not import before, but imports fine now.

gear-example.step.gz

@SoftFever
Copy link
Owner

I had a couple STEP files that were not importing for whatever reason. After throwing OrcaSlicer in a debugger, I noticed the shape_type of the imported object was a 'shell', which should still work for STEP->STL/mesh conversion.

I added the TopAbs_SHELL type to getNamedSolids(...), and indeed it imported fine. Not sure why this shape type was not added to begin with, but adding it seemed to improve support for a variety of STEP files.

I've attached an example of a file that would not import before, but imports fine now.

gear-example.step.gz

Thank you so much.
The change makes sense to me.
I will do some tests

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works well.
Thank you

@SoftFever SoftFever merged commit 3757d96 into SoftFever:main Mar 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants