Add shell type to STEP importer, to fix importing of some STEP files #4247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a couple STEP files that were not importing for whatever reason. After throwing OrcaSlicer in a debugger, I noticed the
shape_type
of the imported object was a 'shell', which should still work for STEP->STL/mesh conversion.I added the
TopAbs_SHELL
type togetNamedSolids(...)
, and indeed it imported fine. Not sure why this shape type was not added to begin with, but adding it seemed to improve support for a variety of STEP files.I've attached an example of a file that would not import before, but imports fine now.
gear-example.step.gz