Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix precedence errors #3611

Merged
merged 4 commits into from
Jan 15, 2024
Merged

fix precedence errors #3611

merged 4 commits into from
Jan 15, 2024

Conversation

foghatredbird
Copy link
Contributor

Fix a handful of precedence errors and 1 logic/precedence error. None of the code will compile as intended without these changes.

Fix a handful of precedence errors and 1 logic/precedence error.  None of the code will compile as intended without these changes.
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @foghatredbird
Those changes look good to me.
I'm just curious, on what platform and with which compiler are you using that reports these issues?

@foghatredbird
Copy link
Contributor Author

Thanks @foghatredbird Those changes look good to me. I'm just curious, on what platform and with which compiler are you using that reports these issues?

Windows VS2019 compiler, but I'm building from the command line and using vs code to edit.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever SoftFever merged commit 1615832 into SoftFever:main Jan 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants