Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profile for Creality Ender 3 V3 KE #3216

Merged
merged 27 commits into from
Dec 21, 2023
Merged

New profile for Creality Ender 3 V3 KE #3216

merged 27 commits into from
Dec 21, 2023

Conversation

bistory
Copy link
Contributor

@bistory bistory commented Dec 21, 2023

This PR adds a new profile for Creality Ender 3 V3 KE.
Previous PR (#3192) was automatically closed, so I open this one...

It hasn't been tested (yet), however, I have the machine so I will fine-tune the profiles if needed.
Basically, it's a Ender 3 V3 SE with a better hotend, a linear rail for X axis and running on Klipper...

@bistory bistory requested a review from SoftFever December 21, 2023 08:40
Copy link
Contributor Author

@bistory bistory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted code simplification

@SoftFever
Copy link
Owner

Thank you for the quick response.
Looks good now.

@SoftFever SoftFever merged commit f5cbe6a into SoftFever:main Dec 21, 2023
@SoftFever
Copy link
Owner

@bistory
I found one more thing we missed for V3 SE/KE,
The default materials are not updated which will cause first time user not see proper materials.
We need to update them as well

"default_materials": "Creality Generic PLA;Creality Generic PETG;Creality Generic ABS"

in file:
resources/profiles/Creality/machine/Creality Ender-3 V3 SE.json
resources/profiles/Creality/machine/Creality Ender-3 V3 KE.json

@bistory
Copy link
Contributor Author

bistory commented Dec 21, 2023

@bistory I found one more thing we missed for V3 SE/KE, The default materials are not updated which will cause first time user not see proper materials. We need to update them as well

"default_materials": "Creality Generic PLA;Creality Generic PETG;Creality Generic ABS"

in file: resources/profiles/Creality/machine/Creality Ender-3 V3 SE.json resources/profiles/Creality/machine/Creality Ender-3 V3 KE.json

Thanks for the feedback I fixed it, do you need a new PR ?

@SoftFever
Copy link
Owner

@bistory I found one more thing we missed for V3 SE/KE, The default materials are not updated which will cause first time user not see proper materials. We need to update them as well

"default_materials": "Creality Generic PLA;Creality Generic PETG;Creality Generic ABS"

in file: resources/profiles/Creality/machine/Creality Ender-3 V3 SE.json resources/profiles/Creality/machine/Creality Ender-3 V3 KE.json

Thanks for the feedback I fixed it, do you need a new PR ?

👍
Yes, please.

@Alexgrau88
Copy link

Hello guys, im new to 3d print world, curios about one issue I'm facing with a Ender3V3KE, installed OrcaSlicer_Windows_Installer_1.8.1.exe , but I'm not saying the printer profile, am I missing something? I see that pull 3216 is merged, is it not committed to V 1.8.1 ?

@bistory
Copy link
Contributor Author

bistory commented Dec 29, 2023

Hello guys, im new to 3d print world, curios about one issue I'm facing with a Ender3V3KE, installed OrcaSlicer_Windows_Installer_1.8.1.exe , but I'm not saying the printer profile, am I missing something? I see that pull 3216 is merged, is it not committed to V 1.8.1 ?

V1.8.1 is 3 weeks old, this PR is one week old ;-)
This PR is already available in v1.9.0-alpha and improvements are in development on my side, I plan to make a new PR as soon as possible before v1.9.0 final release :-)

@Alexgrau88
Copy link

Hello guys, im new to 3d print world, curios about one issue I'm facing with a Ender3V3KE, installed OrcaSlicer_Windows_Installer_1.8.1.exe , but I'm not saying the printer profile, am I missing something? I see that pull 3216 is merged, is it not committed to V 1.8.1 ?

V1.8.1 is 3 weeks old, this PR is one week old ;-) This PR is already available in v1.9.0-alpha and improvements are in development on my side, I plan to make a new PR as soon as possible before v1.9.0 final release :-)

Yes indeed, i tried the 1.9.0 and its there. Thanks for the reply

Copy link

@esn814 esn814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ppl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants