Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequent crashes when switching tabs in preset windows #6261

Closed
2 of 3 tasks
kingr0man opened this issue Jul 26, 2024 · 11 comments · Fixed by #6437
Closed
2 of 3 tasks

Frequent crashes when switching tabs in preset windows #6261

kingr0man opened this issue Jul 26, 2024 · 11 comments · Fixed by #6437
Labels
bug Something isn't working

Comments

@kingr0man
Copy link

kingr0man commented Jul 26, 2024

Is there an existing issue for this problem?

  • I have searched the existing issues

OrcaSlicer Version

2.1.1

Operating System (OS)

Linux

OS Version

Manjaro (Arch) [kernel 6.9.9] + KDE plasma [v 6.0.5]

Additional system information

OS: Manjaro Linux x86_64
Host: 82V2 (Slim 7 ProX 14ARH7)
Kernel: Linux 6.9.9-1-MANJARO
Display (CSO1410): 3072x1920 @ 120Hz (as 1536x960) [Built-in]
DE: KDE Plasma 6.0.5
WM: KWin (Wayland)
CPU: AMD Ryzen 9 6900HS Creator Edition (16) @ 4.93 GHz
GPU 1: AMD Radeon 680M [Integrated]
GPU 2: NVIDIA GeForce RTX 3050 Mobile [Discrete]
Memory: 27.10 GiB

Printer

any

How to reproduce

  1. Click the 'Edit' button on any printer or filament preset
  2. Click on another tab in the preset window (ie try to switch from 'Basic information' to 'Machine G-code' in a printer preset)
  3. Crash

Actual results

Program freezes for a second, then closes itself

Expected results

Tab switches

Project file & Debug log uploads

Here's my full log folder containing several crash logs, mostly if not all from this issue.
log.zip

Checklist of files to include

  • Log file
  • Project file

Anything else?

No response

@kingr0man kingr0man added the bug Something isn't working label Jul 26, 2024
@discip
Copy link
Contributor

discip commented Jul 27, 2024

Same behavior here!
Also on Linux (Manjaro).

@SoftFever
@Noisyfox
Please have a look, this makes it unusable.

@mttr402
Copy link

mttr402 commented Jul 28, 2024

Having the same issue in Linux mint 21.3 Mate with all Orca versions of V2.x. One thing Orca does not like - (dash) in file names as it reports as errors. I tested by renaming the file and it is not flag in log as an error. The fault also occur with a new project started and with no objects added.
[error] 2024-07-28 12:41:16.777044[Thread 0x00007f41e74db380]:calc_exclude_triangles:Unable to create exclude triangles
[error] 2024-07-28 12:41:16.804953[Thread 0x00007f41e74db380]:Unable to open the file/media/3D.objects/Collar.Insert.For.Dremel/Collar.Insert - Collar.Full.3mf
[error] 2024-07-28 12:41:16.804967[Thread 0x00007f41623fd640]:Unable to open the file/home/Downloads/Plier.Plate.step
[error] 2024-07-28 12:41:16.804989[Thread 0x00007f4160bfa640]:Unable to open the file/media/3D.objects/Collar.Insert.For.Dremel/Collar.Insert - Collar.Full.step
[error] 2024-07-28 12:41:16.805029[Thread 0x00007f41633ff640]:Unable to open the file/home/Downloads/LG.Pump.Damper - Full.Part(1).step
[error] 2024-07-28 12:41:16.805031[Thread 0x00007f4160bfa640]:Unable to open the file/home/Downloads/C9.Standard.Bulb.Extractor - Part.Main.Body.step
[error] 2024-07-28 12:41:16.805116[Thread 0x00007f4160bfa640]:Unable to open the file/home/Downloads/Throotle.control.arm.step
[error] 2024-07-28 12:41:16.805108[Thread 0x00007f41692fb640]:Unable to open the file/media/3D.objects/Josie/shot-blocker.STL
[error] 2024-07-28 12:41:16.805174[Thread 0x00007f41e74db380]:Unable to open the file/home/Downloads/Plier.Plate.V3.step
[error] 2024-07-28 12:41:16.805208[Thread 0x00007f4161bfc640]:Unable to open the file/home/Downloads/Hose.Reducer.v1 - Hose.Reducer.v1.full.step
[error] 2024-07-28 12:41:16.805221[Thread 0x00007f41e74db380]:Unable to open the file/home/Downloads/Plier.Plate.3mf
[warning] 2024-07-28 12:41:17.566850[Thread 0x00007f41e74db380]:12:41:17 PM: Warning: Error running JavaScript: Unsupported result type
[warning] 2024-07-28 12:41:17.570003[Thread 0x00007f41e74db380]:12:41:17 PM: Warning: Error running JavaScript: Unsupported result type
[warning] 2024-07-28 12:41:17.578320[Thread 0x00007f41e74db380]:12:41:17 PM: Warning: Error running JavaScript: Unsupported result type
[warning] 2024-07-28 12:41:17.585615[Thread 0x00007f41e74db380]:12:41:17 PM: Warning: Error running JavaScript: Unsupported result type
[error] 2024-07-28 12:41:19.862480[Thread 0x00007f41e74db380]:calc_exclude_triangles:Unable to create exclude triangles
[warning] 2024-07-28 12:41:19.908688[Thread 0x00007f41e74db380]:get_version, get_version not supported,return 00.00.00.00!
[error] 2024-07-28 12:41:29.659737[Thread 0x00007f41e74db380]:calc_exclude_triangles:Unable to create exclude triangles

@adrianbear
Copy link

This occurs when changing a value in a field (for me, particularly a field in one of the extruder tabs) and then changing tabs (to another extruder tab). If you change from the edited field, to another field within the same tab before changing tabs, the error does not seem to occur.

@Noisyfox
Copy link
Collaborator

This occurs when changing a value in a field (for me, particularly a field in one of the extruder tabs) and then changing tabs (to another extruder tab). If you change from the edited field, to another field within the same tab before changing tabs, the error does not seem to occur.

Nice, I managed to reproduce the issue in my VM using this method. Will look into this problem soon.

@Jakeo-93
Copy link

getting this to without changing values as well. Arch based os as well ill just say it is unstable well in the preset tabs.

@Noisyfox
Copy link
Collaborator

getting this to without changing values as well. Arch based os as well ill just say it is unstable well in the preset tabs.

Yeah I noticed that too.

Noisyfox added a commit to Noisyfox/OrcaSlicer that referenced this issue Aug 12, 2024
…ver#6261).

`getWindow()` must return the control itself, not its child control; otherwise the child control will be destroyed twice when the tab container is destroyed.
Noisyfox added a commit to Noisyfox/OrcaSlicer that referenced this issue Aug 12, 2024
…ver#6261).

`getWindow()` must return the control itself, not its child control; otherwise the child control will be destroyed twice when the tab container is destroyed.
@Noisyfox
Copy link
Collaborator

Please give the PR #6437 a try and see if it solves the problem.

Noisyfox added a commit to Noisyfox/OrcaSlicer that referenced this issue Aug 12, 2024
…ver#6261).

`getWindow()` must return the control itself, not its child control; otherwise the child control will be destroyed twice when the tab container is destroyed.
@discip
Copy link
Contributor

discip commented Aug 12, 2024

@Noisyfox

Thank you very much Sir! 😃👍

This solved the issue!

But unfortunately there is more:
This orange symbol is always there except on the Multimaterial tab, even if nothing was changed:

image

After changing any parameter, another symbol appears underneath:

image

If you are lucky enough to be able to klick it (the one underneath) everything works fine, but if you klick the one on top of it, especially after switching tabs, it crashes and closes Orca.

To reproduce:

  1. open Orca
  2. enter Printer settings
  3. click the Machine G-code tab
  4. click the orange symbol in the top left corner

@Noisyfox
Copy link
Collaborator

Hmmmmm seems to be another Linux only issue. Will take a look soon.

Noisyfox added a commit to Noisyfox/OrcaSlicer that referenced this issue Aug 13, 2024
…ver#6261).

`getWindow()` must return the control itself, not its child control; otherwise the child control will be destroyed twice when the tab container is destroyed.
@Noisyfox
Copy link
Collaborator

@Noisyfox

Thank you very much Sir! 😃👍

This solved the issue!

But unfortunately there is more: This orange symbol is always there except on the Multimaterial tab, even if nothing was changed:

image

After changing any parameter, another symbol appears underneath:

image

If you are lucky enough to be able to klick it (the one underneath) everything works fine, but if you klick the one on top of it, especially after switching tabs, it crashes and closes Orca.

To reproduce:

  1. open Orca
  2. enter Printer settings
  3. click the Machine G-code tab
  4. click the orange symbol in the top left corner

log1.txt log2.txt log3.txt

Try the latest PR build. I don't have access to my Linux VM at the moment so I could not test this myself, but hopefully it's fixed now.

@discip
Copy link
Contributor

discip commented Aug 13, 2024

@Noisyfox

Thank you very much! 😃👍

That did indeed solve the issue!

SoftFever pushed a commit that referenced this issue Aug 18, 2024
* Fix crash due to the wrong window get returned in `PointCtrl` (#6261).
`getWindow()` must return the control itself, not its child control; otherwise the child control will be destroyed twice when the tab container is destroyed.

* Fix another crash on Linux caused by unused undo button
henrivdr pushed a commit to henrivdr/OrcaSlicer that referenced this issue Aug 27, 2024
…tFever#6437)

* Fix crash due to the wrong window get returned in `PointCtrl` (SoftFever#6261).
`getWindow()` must return the control itself, not its child control; otherwise the child control will be destroyed twice when the tab container is destroyed.

* Fix another crash on Linux caused by unused undo button
Azio-Pantheon pushed a commit to Pantheon-Design/PantheonSlicer-3 that referenced this issue Oct 17, 2024
* Fix crash due to the wrong window get returned in `PointCtrl` (SoftFever/OrcaSlicer#6261).
`getWindow()` must return the control itself, not its child control; otherwise the child control will be destroyed twice when the tab container is destroyed.

* Fix another crash on Linux caused by unused undo button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants