test(frontend): add tests and fix console errors #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnbearableBear
commented
Jun 27, 2019
| "moduleNameMapper": { | ||
| ".css$": "<rootDir>/test/stubCss.js" | ||
| } | ||
| ] |
There was a problem hiding this comment.
petit oubli du clean css, my bad
revolunet
reviewed
Jun 28, 2019
| facets: result ? result.facets : [], | ||
| items: result ? result.hits.hits : [] | ||
| facets: result && result.facets ? result.facets : [], | ||
| items: result && result.hits ? result.hits.hits : [] |
There was a problem hiding this comment.
pas super lisible le double ternaire ?
const results = {
facets: result && result.facets || [],
items: result && result.hits && result.hits.hits || []
}
revolunet
approved these changes
Jun 28, 2019
lionelB
reviewed
Jun 28, 2019
| ctx.req && | ||
| `${ctx.req.protocol}://${ | ||
| ctx.req.headers.host | ||
| }/static/images/social-preview.png`; |
There was a problem hiding this comment.
le soucis avec ca c'est si on a pas de req on aura pas d'image mais false alors que c'etait pass le cas avant :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alors il dit quoi le code coverage là ??
J'ai mocké le router de next pour éviter de mettre trop de truc tordus dans les fichiers de tests. (Du coup j'ai aussi pu supprimer le HOC renderWithContext pour jest)
@lionelB Finalement ils m'ont été utiles ces tests ça m'a sorti pas mal d'erreurs d'imbrications d'éléments que j'ignorais (pas de
uldans despou deaddressdans desp) mais qui remontaient dans la console en dev que j'avais jamais traité.Après on est d'accord sur le fait qu'il faudrait mettre en place des tests end to end. J'ai une préférence pour nightwatch parce que je trouve le hiboux mignon mais bon