Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): remove heading on footer #3369

Merged
merged 2 commits into from
Mar 18, 2021
Merged

fix(frontend): remove heading on footer #3369

merged 2 commits into from
Mar 18, 2021

Conversation

lionelB
Copy link
Contributor

@lionelB lionelB commented Mar 17, 2021

replace h3 with strong
close #3299

m-maillot
m-maillot requested changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@m-maillot m-maillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The h3 on Avez-vous trouvé la réponse à votre question ? is always here.

CleanShot 2021-03-18 at 11 56 24@2x

see Common/Feedback/index.js

@lionelB
Copy link
Contributor Author

lionelB commented Mar 18, 2021

@m-maillot already updated :) we need to wait the new deploy env

@m-maillot
Copy link
Contributor

Ok, I didn't see the modification in Common/Feedback/index.js during my code review... strange...

@lionelB lionelB requested a review from m-maillot March 18, 2021 11:22
@lionelB lionelB merged commit 711da5e into master Mar 18, 2021
@lionelB lionelB deleted the lionelb/fix-h3 branch March 18, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-maillot m-maillot m-maillot approved these changes

@revolunet revolunet Awaiting requested review from revolunet

@douglasduteil douglasduteil Awaiting requested review from douglasduteil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enlever des balises H3 inutiles présentes sur les pages
3 participants
@lionelB @m-maillot @SocialGroovyBot