fix(frontend): backlink #1339
Merged
fix(frontend): backlink #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelB
reviewed
Sep 27, 2019
| @@ -103,7 +103,7 @@ exports[`<SearchResults/> should render results 1`] = ` | |||
| > | |||
| <a | |||
| class="c2" | |||
| href="/question/mer-il-est-fou?q=search test" | |||
| href="/question/mer-il-est-fouq=search test" | |||
There was a problem hiding this comment.
J'ai oublié le "?" dans la string 😞
lionelB
reviewed
Sep 27, 2019
| }} | ||
| as={`/${getRouteBySource(item.source)}/${item.slug}?q=${query}`} | ||
| as={`/${getRouteBySource(item.source)}/${item.slug}${query && |
There was a problem hiding this comment.
${query ? query : ""} sinon la valeur "falsy" de query va etre interprété en string
lionelB
reviewed
Sep 27, 2019
| }} | ||
| as={`/${getRouteBySource(source)}/${slug}?q=${query}`} | ||
| as={`/${getRouteBySource(source)}/${slug}${query && `q=${query}`}`} |
lionelB
reviewed
Sep 27, 2019
| @@ -11,7 +11,7 @@ import { LinkContent } from "./LinkContent"; | |||
| const ListLink = ({ | |||
| focused, | |||
| item: { source, slug, url }, | |||
| query, | |||
| query = null, | |||
There was a problem hiding this comment.
pourquoi cette valeur par default ?
There was a problem hiding this comment.
Un oublie je faisais des test, j'e l'ai vraiment faite à l'arrache cette PR !
lionelB
approved these changes
Sep 27, 2019
|
Merci j'ai vraiment fait n'imp sur cette PR ! |
UnbearableBear
force-pushed
the
manu/backlink-fix
branch
from
0761cab to
566eb14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed, fix the issue where the theme's slug is passed in the "q" param of a fiche