fix(frontend): improve CCN explanation text #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementChapalain
changed the title
replace html entity `'` with its typographical quote equivalent
fix missing last htmlentity
| @@ -12,7 +12,7 @@ describe("<ConventionExplainer />", () => { | |||
| const { getByText, queryByText, container } = render( | |||
| <ConventionExplainer /> | |||
| ); | |||
| fireEvent.click(getByText(/Explications sur les conventions/)); | |||
| fireEvent.click(getByText(/Plus d'informations sur les conventions collectives/)); | |||
There was a problem hiding this comment.
Il y arrive même si c'est pas le bon accent là ?
lionelB
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1011
pas sur d'avoir bien fait tous les changements notamment au niveau des tests / snapshots 😄
à votre bon cœur pour de la review.