Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lionelb/update elastic mapping #566

Merged
merged 11 commits into from
Mar 6, 2019
Merged

Conversation

lionelB
Copy link
Contributor

@lionelB lionelB commented Mar 1, 2019

  • maj de la config d'elastic pour améliorer les resultats
    • requete longue
    • recherche par article id (L-2413-1)
  • Creation d'un package js pour les stopwords (pour partager la config entre node et python)
  • refacto du exludeSource
  • nettoyage de l'ancienne prop all_text non utilisée

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #566 into master will increase coverage by 1.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   73.03%   74.44%   +1.41%     
==========================================
  Files          94      120      +26     
  Lines        1094     1225     +131     
  Branches      170      186      +16     
==========================================
+ Hits          799      912     +113     
- Misses        265      279      +14     
- Partials       30       34       +4
Flag Coverage Δ
#true 72.98% <ø> (-0.05%) ⬇️
Impacted Files Coverage Δ
...l-api/src/server/routes/suggest/suggest.elastic.js 100% <ø> (ø) ⬆️
...ail-api/src/server/routes/search/search.elastic.js 100% <ø> (ø) ⬆️
packages/code-du-travail-ui/src/Card.js 100% <0%> (ø)
...ode-du-travail-data/dataset/tag_extractor/index.js 85% <0%> (ø)
packages/code-du-travail-ui/src/Categories.js 100% <0%> (ø)
packages/code-du-travail-ui/src/LargeLink.js 100% <0%> (ø)
packages/code-du-travail-ui/src/Section.js 100% <0%> (ø)
packages/code-du-travail-ui/src/icons/Search.js 100% <0%> (ø)
packages/code-du-travail-ui/src/Container.js 100% <0%> (ø)
packages/code-du-travail-ui/src/NoAnswer.js 100% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ca786...e74ad07. Read the comment docs.

@lionelB
Copy link
Contributor Author

lionelB commented Mar 4, 2019

@douglasduteil j'ai crée un nouveau packages "@cdt/data...stopwords" mais on dirait qu'api ne le trouve pas
il me semble qu'on avait deja eu le probleme mais je me rappelle plus ce qu'on avait fait :/

@douglasduteil
Copy link
Contributor

You might want to edit the master Dockerfile maybe

@lionelB
Copy link
Contributor Author

lionelB commented Mar 5, 2019

je peux merger ? poke @douglasduteil @revolunet ?

@lionelB lionelB merged commit 09e0b96 into master Mar 6, 2019
@lionelB lionelB deleted the lionelb/update-elastic-mapping branch March 6, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants