Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug ES] rechercher un article du code du travail par son code/ format de saisie/pertinence #498

Closed
jrduscher opened this issue Feb 1, 2019 · 5 comments
Closed

[Bug ES] rechercher un article du code du travail par son code/ format de saisie/pertinence #498

jrduscher opened this issue Feb 1, 2019 · 5 comments
Labels
bug s: prêt pour dev
Milestone
sprint #11

Comments

@jrduscher
Copy link
Contributor

jrduscher commented Feb 1, 2019 •
edited
Loading

test L. 1242-8.

  • L1242-8 : pas de réponse
  • L.1242-8: L'article correspondant ne matche pas.
  • L 1242-8 : pas de réponse

Résultat attendu https://codedutravail-dev.num.social.gouv.fr/code-du-travail/article-l1242-8?q=La%20dur%C3%A9e%20totale%20du%20contrat%20%C3%A0%20dur%C3%A9e%20d%C3%A9termin%C3%A9e&search=0

étendre la recherche aux titres des contenus
@jrduscher jrduscher added this to the Livraison 1.9 milestone Feb 1, 2019
@lionelB
Copy link
Contributor

lionelB commented Feb 1, 2019 •
edited
Loading

effectivement, pour l'instant on ne cherche que dans le texte et pas plus dans le titre, ce qui fait qu'on ne remonte aucun article
Fix: remplacer le match {text { query }} par un multimatch text/title

@revolunet
Copy link
Member

nb: ca marchait avait le retrait du fuzzy

@lionelB
Copy link
Contributor

lionelB commented Feb 1, 2019 •
edited
Loading

oui ce que je voulais dire c'est que çà correspondait au modifs qu'on a fait sur ES. Il faudrait rajouter un cas dans les TU

@ClementChapalain ClementChapalain removed this from the Livraison 1.9 milestone Feb 21, 2019
@lionelB lionelB added this to the sprint #11 milestone Feb 27, 2019
lionelB added a commit that referenced this issue Mar 6, 2019
@lionelB
fix(data): update elastic configuration (#566)
09e0b96 
* fix(data): update elastic french stop words

* fix(data): add standart analyzer for phrase suggester

* fix(api): make exludeSource simpler

* fix(api): allow searching on both text and title

* fix(data): improve article id search

* fix(data): remove all_text prop from indexing

* feat(data): create a node package for stopwords

* refactor(data): use stopwords list from json

* refactor(api): backport  elastic settings

* chore(data): fix lint python

* chore(Dockerfile): add stop_words package

fix #537, #498, #112
@ClementChapalain
Copy link
Contributor

J'ai vu que tu l'avais montré à la démo @lionelB est-ce qu'on peut clore cette tâche ?

@lionelB
Copy link
Contributor

lionelB commented Mar 12, 2019

yep closed by #566

@lionelB lionelB closed this as completed Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug s: prêt pour dev
Projects
None yet
Milestone
sprint #11
Development

No branches or pull requests
4 participants
@revolunet @lionelB @ClementChapalain @jrduscher