fix(data): add a check ensure service-public content (#2956)

ensure content referenced in contribution are not missing closes #2042
SocialGouv · Sep 17, 2020 · f6e9b6c · f6e9b6c
1 parent f4d39d8
commit f6e9b6c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 7 deletions.
diff --git a/packages/code-du-travail-data/dataset/fiches_service_public/filter.js b/packages/code-du-travail-data/dataset/fiches_service_public/filter.js
@@ -1,15 +1,15 @@
 const uniqBy = require("lodash.uniqby");
 
-const filter = fiches => {
-  const filteredFiches = fiches.filter(fiche => {
+const filter = (fiches) => {
+  const filteredFiches = fiches.filter((fiche) => {
     const arianeIDs = fiche.children[0].children
-      .find(el => el.name === "FilDAriane")
+      .find((el) => el.name === "FilDAriane")
       .children.reduce((ids, el) => {
         if (el.name === "Niveau") ids.push(el.attributes.ID);
         return ids;
       }, []);
 
-    const matchFilDAriane = id => arianeIDs.includes(id);
+    const matchFilDAriane = (id) => arianeIDs.includes(id);
 
     if (excludeFicheId.some(matchFilDAriane)) {
       return false;
@@ -29,7 +29,7 @@ const filter = fiches => {
     // Par défaut, on exclue
     return false;
   });
-  return uniqBy(filteredFiches, fiche => fiche.children[0].attributes.ID);
+  return uniqBy(filteredFiches, (fiche) => fiche.children[0].attributes.ID);
 };
 
 // Liste fournie par @jrduscher

diff --git a/packages/code-du-travail-data/dataset/fiches_service_public/index.js b/packages/code-du-travail-data/dataset/fiches_service_public/index.js
@@ -34,8 +34,8 @@ const fullFiches = [].concat(
   )
 );
 
-const getFichesSP = () =>
-  filter(fullFiches)
+const getFichesSP = () => {
+  const fiches = filter(fullFiches)
     .map(format)
     .filter(Boolean)
     .map(
@@ -71,4 +71,15 @@ const getFichesSP = () =>
       }
     );
 
+  contribFicheId.forEach((idFiche) => {
+    if (fiches.find(({ id }) => idFiche === id) === undefined) {
+      throw Error(
+        `[FICHE-SP] The ${idFiche} from service-public is embeded in a contribution and was not found`
+      );
+    }
+  });
+
+  return fiches;
+};
+
 module.exports = { getFichesSP };