Feat/icicles d3 hover #1277
Feat/icicles d3 hover #1277
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/refactor-icicles-d3 #1277 +/- ##
=========================================================
Coverage 80.64% 80.64%
=========================================================
Files 121 121
Lines 3069 3069
Branches 410 409 -1
=========================================================
Hits 2475 2475
Misses 590 590
Partials 4 4 Continue to review full report at Codecov.
|
| @@ -14,3 +14,8 @@ body { | |||
| h4 { | |||
| font-family: "Quicksand", sans-serif; | |||
| } | |||
|
|
|||
| #icicles { | |||
There was a problem hiding this comment.
On n'utilise pas trop de scss d'habitude, on préfère le CSS in JS. Regarde si tu ne peux pas plutôt utiliser styled-components par exemple
| @@ -0,0 +1,89 @@ | |||
| import { ROOT_FF_ID } from "reducers/files-and-folders/files-and-folders-selectors"; | |||
| import { FilesAndFolders } from "reducers/files-and-folders/files-and-folders-types"; | |||
| import { fromFileName } from "./../../../util/color/color-util"; | |||
There was a problem hiding this comment.
| import { fromFileName } from "./../../../util/color/color-util"; | |
| import { fromFileName } from "util/color/color-util"; |
| (element) => | ||
| element?.children.map((childId) => filesAndFolders[childId]) ?? [] | ||
| ) | ||
| .sum((d) => d?.file_size ?? 0); |
There was a problem hiding this comment.
Remplacer d par un nom de variable plus explicite
| .attr("width", ({ y0, y1 }) => y1 - y0 - 1) | ||
| .attr("height", (d) => getRectangleHeight(d)) | ||
| .attr("fill-opacity", 0.5) | ||
| .attr("fill", (d: any) => { |
There was a problem hiding this comment.
Renommer d ici aussi, et le typer si possible
| return fromFileName(d.data.name); | ||
| }) | ||
| .style("cursor", "pointer") | ||
| .on("dblclick", (_, currentRect) => handleZoom(_, currentRect, elements)); |
There was a problem hiding this comment.
Si handleZoom a besoin de _, ne pas nommer cette variable ainsi car elle est utilisée
| .text((d: any) => d.data.name); | ||
|
|
||
| cell.append("title").text( | ||
| (d: any) => |
There was a problem hiding this comment.
Idem, essayer de trouver un meilleur nom et pourquoi pas un type pour d
| }; | ||
|
|
||
| export const createSubtitle = (title) => { | ||
| return title |
There was a problem hiding this comment.
Peut se simplifier en retirant l'accolade et le return
| dimensionsTarget[dimensions.data.id]; | ||
|
|
||
| export const handleZoom = (_, currentRect, elements) => { | ||
| let { root, cell, rect, title, subtitle } = elements; |
There was a problem hiding this comment.
| let { root, cell, rect, title, subtitle } = elements; | |
| const { root, cell, rect, title, subtitle } = elements; |
| @@ -0,0 +1,79 @@ | |||
| import * as d3 from "d3"; | |||
There was a problem hiding this comment.
Déplacer ce fichier dans le dossier utils, et écrire des tests pour les fonctions exportées
No description provided.