Skip to content

Commit

Permalink
fix: notarize
Browse files Browse the repository at this point in the history
  • Loading branch information
TimotheeMalard committed May 15, 2024
1 parent 81e3b51 commit 2a54be6
Show file tree
Hide file tree
Showing 7 changed files with 601 additions and 53,420 deletions.
1 change: 1 addition & 0 deletions .env.dist
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ GITHUB_TOKEN=
# for notarize
APPLE_ID=
APPLE_ID_PASSWORD=
APPLE_ID_TEAM=
# osx code sign cert - can be base64-ed file or path
CSC_LINK=
CSC_KEY_PASSWORD=
Expand Down
14 changes: 5 additions & 9 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ jobs:
with:
name: compile-dist
path: dist/

build:
if: ${{ success() }}
needs: compile
Expand All @@ -136,6 +135,7 @@ jobs:
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
APPLE_ID_TEAM: ${{ secrets.APPLE_ID_TEAM }}
ELECTRON_CACHE: ${{ github.workspace }}/.cache/electron
ELECTRON_BUILDER_CACHE: ${{ github.workspace }}/.cache/electron-builder

Expand All @@ -151,37 +151,33 @@ jobs:
- name: Yarn install
run: |
yarn config set network-timeout 300000
yarn --frozen-lockfile --perfer-offline
yarn --frozen-lockfile --prefer-offline
- name: Replace version in package.json
shell: bash
run: |
yarn global add replace
$(yarn global bin)/replace '"version": "${{ needs.compile.outputs.current-version }}"' '"version": "${{ needs.compile.outputs.next-version }}"' package.json
yarn replaceForChannel
####### Activate only if windows msi build fail with "ICE error"
# - name: Hack msi compilation
# if: contains(matrix.os, 'windows')
# shell: bash
# run: $(yarn global bin)/replace 'lightArgs\.push\(\.\.\.objectFiles\);' 'lightArgs.push("-sval", ...objectFiles);' node_modules/app-builder-lib/out/targets/MsiTarget.js
- name: Download dist
uses: actions/download-artifact@v4
with:
name: compile-dist
path: dist/
- name: Download cetificates
- name: Download certificates
uses: actions/download-artifact@v4
with:
name: certificates
- name: Build bin
run: yarn dist:${{ matrix.target }}
env:
USE_HARD_LINKS: false
- name: Archive bin
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.target }}-bin
path: |
electron/dist/*/archifiltre*.*
electron/dist/*/latest*.yml
release:
needs: build
runs-on: ubuntu-latest
Expand Down
7 changes: 7 additions & 0 deletions electron-builder.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module.exports = {
mac: {
notarize: {
teamId: process.env.APPLE_ID_TEAM,
},
},
};
Loading

0 comments on commit 2a54be6

Please sign in to comment.