Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use master branches for parity dependencies #796

Merged
merged 8 commits into from
Apr 2, 2023
Merged

Use master branches for parity dependencies #796

merged 8 commits into from
Apr 2, 2023

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Mar 29, 2023 •
edited
Loading

The current bridge hub work relies on master branches for polkadot and substrate dependencies.

The upgrade consists of:

  1. Remove the deprecated generate_store macro. [Deprecation] deprecate trait Store in FRAME storage paritytech/polkadot-sdk#222
  2. Remove deprecated Weights::from_ref_time. Deprecate Weight::from_{ref_time, proof_size} paritytech/substrate#13475

Snowfork Cumulus companion: Snowfork/cumulus#7

@alistair-singh alistair-singh mentioned this pull request Mar 29, 2023
Merged
@alistair-singh alistair-singh marked this pull request as ready for review March 29, 2023 07:59
vgeddes
vgeddes reviewed Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also update codec, serde, and scale-info deps to match Substrate master, where I'm seeing the following versions in use:

  • codec: 3.2.2
  • serde: 1.0.136
  • scale-info: 2.1.1

@alistair-singh
Copy link
Contributor Author

Lets also update codec, serde, and scale-info deps to match Substrate master, where I'm seeing the following versions in use:

The current branch I have based this on bridge-hub-rococo-wococo has the following versions with the bridge-hub-rococo runtime.

  • codec: 3.2.1
  • serde: 1.0.156
  • scale-info: 2.3.1

I have updated our pallets to match those versions instead.
See https://github.com/Snowfork/cumulus/blob/alistair/use-rococo-bridge/parachains/runtimes/bridge-hubs/bridge-hub-rococo/Cargo.toml

yrong
yrong approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vgeddes
vgeddes approved these changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vgeddes vgeddes merged commit 3db2d69 into main Apr 2, 2023
@vgeddes vgeddes deleted the alistair/use-rococo-bridge branch April 2, 2023 10:00
vgeddes added a commit that referenced this pull request Apr 2, 2023
@vgeddes
Update for #796
f440d05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgeddes vgeddes vgeddes approved these changes

@yrong yrong yrong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alistair-singh @vgeddes @yrong