Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade tf for testing #625

Merged
merged 13 commits into from
Jul 30, 2021
Merged

fix: Upgrade tf for testing #625

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
82ac5bf
fix: Upgrade tf for testing
alldoami Jul 29, 2021
8b6bfa1
update readme
alldoami Jul 29, 2021
aaa8cb7
period
alldoami Jul 29, 2021
622c326
make deps
alldoami Jul 29, 2021
ebb8349
update go files
alldoami Jul 29, 2021
b6f3596
gotidy and fix version string
jakeyheath Jul 29, 2021
529c23c
empty
alldoami Jul 29, 2021
afab646
revert go.mod
jakeyheath Jul 29, 2021
f17f84f
Merge branch 'adoami/upgrade-tf-for-testing' of github.com:chanzucker…
jakeyheath Jul 29, 2021
b0b12d5
revert go.sum
jakeyheath Jul 29, 2021
ac2e13e
empty
alldoami Jul 29, 2021
0b54ac4
go get -u
alldoami Jul 29, 2021
4b1b863
fixes
alldoami Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export DIRTY=$(shell if `git diff-index --quiet HEAD --`; then echo false; else
LDFLAGS=-ldflags "-w -s -X github.com/chanzuckerberg/go-misc/ver.GitSha=${SHA} -X github.com/chanzuckerberg/go-misc/ver.Version=${VERSION} -X github.com/chanzuckerberg/go-misc/ver.Dirty=${DIRTY}"
export BASE_BINARY_NAME=terraform-provider-snowflake_v$(VERSION)
export GO111MODULE=on
export TF_ACC_TERRAFORM_VERSION=0.12.29
export TF_ACC_TERRAFORM_VERSION=0.13
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add the readme that there's now a version requirement for the provider

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alldoami @edulop91 I think this is failing because it should be 0.13.x in this case 0.13.0 not only 0.13

export SKIP_EXTERNAL_TABLE_TESTS=true

go_test ?= -
Expand Down