docs: NO-SNOW (issue #1040) add a little bit more clarification how to spec… #3321
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify location for the external table
|
Integration tests cancelled for f88b0e37e9bac943336ce3ae806c4ef39f1e0b05 |
sfc-gh-dszmolka
requested review from
sfc-gh-jcieslak,
sfc-gh-asawicki and
sfc-gh-jmichalak
sfc-gh-jmichalak
requested changes
Jan 7, 2025
* added example in resource.tf (for snowflake_external_table) * using the preferred format for dynamic value in external_table.go
|
Integration tests failure for efdf842cf92d7394c19c64f97d0d227bce0de85b |
sfc-gh-asawicki
approved these changes
Jan 9, 2025
|
@sfc-gh-jmichalak review has been addressed, but merging is blocked due to the 'changes requested' state. Can you please re-review ? Thank you in advance ! |
sfc-gh-jmichalak
approved these changes
Jan 9, 2025
sfc-gh-dszmolka
deleted the
NO-SNOW-extend-docs-external-table-location
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Doc-only change, no code was modified.
Looks like
locationcan use a bit more clarification as users encounter an error when trying to intuitively populate this parameter.Using working example from the linked issue.
References
closes #1040