Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Generate multiline by default #3315

Merged
merged 4 commits into from
Jan 8, 2025
Merged

chore: Generate multiline by default #3315

merged 4 commits into from
Jan 8, 2025

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Dec 20, 2024 •
edited
Loading

Enable generating multiline config building:

  • use overrides to decide what type of method should be generated
  • add it to the known cases (all user types, all function types, and all procedure types)
  • apply change only to resource models; it is still an extension method for the provider config model
  • adjusted existing models and acceptance tests

@github-actions GitHub Actions
Copy link

Integration tests failure for 6946308d26182ad2264aa4fd3fc5d7d7e736b3bc

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Integration tests failure for 6946308d26182ad2264aa4fd3fc5d7d7e736b3bc

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review January 8, 2025 16:04
@sfc-gh-asawicki sfc-gh-asawicki merged commit 292d1fe into dev Jan 8, 2025
9 of 10 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the generate-multiline-by-default branch January 8, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak Awaiting requested review from sfc-gh-jcieslak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-asawicki @sfc-gh-jmichalak