Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: apply identifier conventions to grants #3008

Merged
merged 11 commits into from
Aug 23, 2024
Merged

chore: apply identifier conventions to grants #3008

merged 11 commits into from
Aug 23, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Aug 20, 2024 •
edited
Loading

Changes

  • Applied identifier conventions to grant resources
    • Used helpers.EncodeResourceIdentifier where possible
    • Used sdk.ParseXIdentifier where possible
    • Applied quote ignore on identifier fields
  • Added tests to check the migration between the versions

Note: Some of the changes like resource_identifier.go, custom_diff.go, diff_suppressions.go were taken from #2996

@github-actions GitHub Actions
Copy link

Integration tests failure for d99307b4e91e01f371e3f6c2fd3534c98343f304

@github-actions GitHub Actions
Copy link

Integration tests failure for 02ae33c50965a1a411a436c9cb9e47255c7e556e

@github-actions GitHub Actions
Copy link

Integration tests failure for c35c2526bf0434cb02049a3830e61ff6907eb4d9

sfc-gh-jmichalak
sfc-gh-jmichalak requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. My comments relate to other resources affected by this PR. Also, comments from #2996 are valid here.

pkg/resources/grant_account_role_acceptance_test.go Show resolved Hide resolved
pkg/resources/grant_application_role_acceptance_test.go Show resolved Hide resolved
pkg/resources/grant_ownership.go Outdated Show resolved Hide resolved
pkg/resources/grant_ownership_acceptance_test.go Outdated Show resolved Hide resolved
pkg/resources/share.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests failure for 3f07fefd45d96382d115509203a10f5d0b58529a

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the identifier-conventions-on-grants branch from 3221374 to dd7e9d6 Compare August 22, 2024 10:58
@github-actions GitHub Actions
Copy link

Integration tests failure for 322137401601d49be18cdd777502cfd2550c2214

@github-actions GitHub Actions
Copy link

Integration tests failure for dd7e9d6a181fc3d511a8b5b97d1dd0d4ff131c56

@sfc-gh-jcieslak
Merge branch 'refs/heads/main' into identifier-conventions-on-grants
5b96e28 
# Conflicts:
#	pkg/helpers/resource_identifier.go
#	pkg/resources/account_role.go
#	pkg/resources/account_role_acceptance_test.go
#	pkg/resources/common.go
#	pkg/resources/custom_diffs.go
#	pkg/resources/diff_suppressions.go
#	pkg/resources/grant_ownership_test.go
#	pkg/resources/grant_privileges_to_share_identifier_test.go
#	pkg/sdk/identifier_parsers_test.go
@sfc-gh-jcieslak
wip
917b321
@github-actions GitHub Actions
Copy link

Integration tests cancelled for ef4ac8b2108a4c7c44a1c292d28433ce42cffca6

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review August 22, 2024 14:49
@github-actions GitHub Actions
Copy link

Integration tests failure for 917b32180b778c8f81a711f14375c3831688a04c

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit d7780ae into main Aug 23, 2024
8 of 9 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the identifier-conventions-on-grants branch August 23, 2024 06:24
@snowflake-release-please snowflake-release-please bot mentioned this pull request Aug 22, 2024
Merged
sfc-gh-jcieslak pushed a commit that referenced this pull request Sep 4, 2024
@snowflake-release-please
chore(main): release 0.95.0 (#2977)
cd1636c 
🤖 I have created a release *beep* *boop*
---


##
[0.95.0](v0.94.1...v0.95.0)
(2024-09-04)


### 🎉 **What's new:**

* Add change_tracking, row access policy and aggregation policy to views
([#2988](#2988))
([1f88bb1](1f88bb1))
* Add fully_qualified_name to all resources
([#2990](#2990))
([1b0462f](1b0462f))
* Add identifier parsers
([#2957](#2957))
([824ec52](824ec52))
* Add identifier with arguments
([#2979](#2979))
([00ae1c5](00ae1c5))
* Add timeouts block to cortex
([#3004](#3004))
([34d764b](34d764b))
* Add user parameters to resource
([#2968](#2968))
([f4ae380](f4ae380))
* Conclude user rework
([#3036](#3036))
([23e4625](23e4625))
* database role v1 readiness
([#3014](#3014))
([c4db255](c4db255))
* Identifier with arguments for procedure and external function
([#2987](#2987))
([f13cc5c](f13cc5c))
* Rework user resource
([#3026](#3026))
([bde2638](bde2638)),
closes
[#1572](#1572)
* Rework users datasource
([#3030](#3030))
([751239b](751239b)),
closes
[#2902](#2902)
* Upgrade view sdk
([#2969](#2969))
([ef2d50a](ef2d50a))
* View rework part 2
([#3021](#3021))
([e05377d](e05377d))
* View rework part 3
([#3023](#3023))
([195b41c](195b41c))


### 🔧 **Misc**

* Add annotation about fully_qualified_name and fix handling granteeName
([#3009](#3009))
([94e6345](94e6345))
* Apply identifier conventions
([#2996](#2996))
([5cbea84](5cbea84))
* apply identifier conventions to grants
([#3008](#3008))
([d7780ae](d7780ae))
* Clean collection utils
([#3028](#3028))
([426ddb1](426ddb1))
* Clean old assertions
([#3029](#3029))
([ad657eb](ad657eb))
* Conclude identifiers rework
([#3011](#3011))
([c1b53f3](c1b53f3))
* Improve user test and add manual test for user default database and
role
([#3035](#3035))
([6cb0b4e](6cb0b4e))
* Use new identifier with arguments in function, external function and
procedure grants
([#3002](#3002))
([5053f8b](5053f8b))
* User improvements
([#3034](#3034))
([65b64d7](65b64d7))


### 🐛 **Bug fixes:**

* database tests and introduce a new parameter
([#2981](#2981))
([3bae7f6](3bae7f6))
* Fix custom diffs for fields with diff supression
([#3032](#3032))
([2499602](2499602))
* Fix default secondary roles after BCR 2024_07
([#3040](#3040))
([2ca465a](2ca465a)),
closes
[#3038](#3038)
* Fix issues 2972 and 3007
([#3020](#3020))
([1772387](1772387))
* Fix known user resource issues
([#3013](#3013))
([a5dfeac](a5dfeac))
* identifier issues
([#2998](#2998))
([6fb76b7](6fb76b7))
* minor issues
([#3027](#3027))
([467b06e](467b06e)),
closes
[#3015](#3015)
[#2807](#2807)
[#3025](#3025)
* Nuke users
([#2971](#2971))
([0d90cc9](0d90cc9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jcieslak @sfc-gh-asawicki @sfc-gh-jmichalak