Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix ACCOUNT PARAMETERS option failover group resource #2522

Merged
merged 3 commits into from
Feb 20, 2024
Merged

fix: Fix ACCOUNT PARAMETERS option failover group resource #2522

merged 3 commits into from
Feb 20, 2024

Conversation

sfc-gh-asawicki
Copy link
Collaborator

  • SHOW FAILOVER GROUPS return PARAMETERS instead of ACCOUNT PARAMETERS
  • acceptance tests were unskipped by adding environment variable
  • SDK integration tests still stay skipped

References: #2517

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review February 19, 2024 12:26
@github-actions GitHub Actions
Copy link

Integration tests failure for 6e1374f9029083759cb84a1f4e3cd3a0edfe2abc

@sfc-gh-asawicki sfc-gh-asawicki mentioned this pull request Feb 19, 2024
Closed
@github-actions GitHub Actions
Copy link

Integration tests failure for 6e1374f9029083759cb84a1f4e3cd3a0edfe2abc

@sfc-gh-asawicki
Prove and fix issue #2517
25024e8 
Add to migration guide

Remove comment
@sfc-gh-asawicki sfc-gh-asawicki force-pushed the 2517-fix-failover-groups branch from 6e1374f to 25024e8 Compare February 19, 2024 13:35
@github-actions GitHub Actions
Copy link

Integration tests failure for 25024e88ff3816082c14db3e3da29d61fad98fb8

1 similar comment
@github-actions GitHub Actions
Copy link

Integration tests failure for 25024e88ff3816082c14db3e3da29d61fad98fb8

@github-actions GitHub Actions
Copy link

Integration tests failure for 9e044409021a769c4c9964a4aac491cd9ef1d4c7

@github-actions GitHub Actions
Copy link

Integration tests failure for 962778c3f0bf88ddf324bce4e278b510cd005284

@github-actions GitHub Actions
Copy link

Integration tests success for 962778c3f0bf88ddf324bce4e278b510cd005284

@sfc-gh-asawicki sfc-gh-asawicki merged commit 61883f3 into main Feb 20, 2024
9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the 2517-fix-failover-groups branch February 20, 2024 06:35
@snowflake-release-please snowflake-release-please bot mentioned this pull request Feb 20, 2024
Merged
This was referenced Feb 22, 2024
Merged
Closed
sfc-gh-jcieslak pushed a commit that referenced this pull request Feb 28, 2024
@snowflake-release-please
chore(main): release 0.87.0 (#2513)
07ce00a 
🤖 I have created a release *beep* *boop*
---


##
[0.87.0](v0.86.0...v0.87.0)
(2024-02-28)


### 🎉 **What's new:**

* Add network rule to the sdk
([#2526](#2526))
([b379565](b379565))
* supports collation of table column
([#2496](#2496))
([56771f1](56771f1))


### 🔧 **Misc**

* Clean up environment variables in tests and on CI
([#2543](#2543))
([9a10cb1](9a10cb1))
* replace warning in new grant resources with info log
([#2521](#2521))
([c3014b9](c3014b9))


### 🐛 **Bug fixes:**

* data retention days follow up
([#2566](#2566))
([7aba384](7aba384))
* data retention time parameters
([#2502](#2502))
([76abf21](76abf21))
* data retention time parameters follow-up
([#2530](#2530))
([5544544](5544544))
* Demote warning to info and set volatility for procedures and functions
([#2567](#2567))
([abaad7c](abaad7c)),
closes
[#2536](#2536)
* Fix ACCOUNT PARAMETERS option failover group resource
([#2522](#2522))
([61883f3](61883f3)),
closes
[#2517](#2517)
* Fix failover group alter syntax and suppression for pipe statement
([#2562](#2562))
([24d76c3](24d76c3))
* Fix few tests
([#2515](#2515))
([a523a6b](a523a6b))
* Fix provider config hierarchy
([#2551](#2551))
([677a12b](677a12b))
* Fix query_results in unsafe_execute resource
([#2512](#2512))
([94ca158](94ca158)),
closes
[#2491](#2491)
* Fix replication for database resource
([#2524](#2524))
([767fbce](767fbce)),
closes
[#2021](#2021)
* Fix show by id for external functions
([#2531](#2531))
([d910a84](d910a84)),
closes
[#2528](#2528)
* Fix various small problems
([#2552](#2552))
([f558ce6](f558ce6))
* Granting database roles
([#2511](#2511))
([dc27d64](dc27d64)),
closes
[#2402](#2402)
* grants on external volumes
([#2538](#2538))
([1de9a29](1de9a29))
* Handle old reference for table_id in table constraint resource
([#2558](#2558))
([d1e8912](d1e8912)),
closes
[#2535](#2535)
* loosen identifier field validation for account object identifiers
([#2564](#2564))
([a5ed8cd](a5ed8cd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-asawicki @sfc-gh-jcieslak