Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Shader compilation" in README #108

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

timoffex
Copy link
Contributor

The example was a bit outdated:

  • Used the "package" terminology which has been replaced by "module"
  • The import didn't work for me
  • Missing parameter from ShaderCompileStep.create()

Side note: I don't really understand the purpose of the output flag parameter. What else can it be other than "-o"?

Side note 2: I'm new to Zig, and for some reason the alignment stuff doesn't work for me. I have to use the compiled shaders with @ptrCast(@alignCast(&my_shader)); the @as([*]const u32, @ptrCast(&my_shader)) approach doesn't work. If I knew the right way to do this, I would have included it in the example snippet.

@Snektron Snektron merged commit 14259cc into Snektron:master Sep 25, 2023
1 check passed
@Snektron
Copy link
Owner

Thanks

@timoffex timoffex deleted the fix-shader-comp-example branch September 25, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants