Parameterise repository reference in Dockerfile

This commit parameterises the KeyDB source code repository URL and branch values in the Dockerfile for improved reusability. Signed-off-by: Stephanos Ioannidis <[email protected]>
Snapchat · Feb 23, 2024 · 7b98920 · 7b98920
1 parent 2ad14de
commit 7b98920
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/pkg/docker/Dockerfile b/pkg/docker/Dockerfile
@@ -23,7 +23,8 @@ RUN set -eux; \
         gosu --version; \
         gosu nobody true
 # build KeyDB
-ARG BRANCH
+ARG REPO=https://github.com/Snapchat/KeyDB.git
+ARG BRANCH=main
 RUN set -eux; \
         \
         savedAptMark="$(apt-mark showmanual)"; \
@@ -47,7 +48,7 @@ RUN set -eux; \
                 libsnappy-dev \
                 libssl-dev \
                 git; \
-        cd /tmp && git clone --branch $BRANCH https://github.com/Snapchat/KeyDB.git --recursive; \
+        cd /tmp && git clone --branch $BRANCH $REPO --recursive; \
         cd /tmp/KeyDB; \
         # disable protected mode as it relates to docker
         grep -E '^ *createBoolConfig[(]"protected-mode",.*, *1 *,.*[)],$' ./src/config.cpp; \

diff --git a/pkg/docker/Dockerfile_Alpine b/pkg/docker/Dockerfile_Alpine
@@ -2,7 +2,8 @@ FROM alpine:3.18
 # add our user and group first to make sure their IDs get assigned consistently, regardless of whatever dependencies get added
 RUN addgroup -S -g 1000 keydb && adduser -S -G keydb -u 999 keydb
 RUN mkdir -p /etc/keydb
-ARG BRANCH
+ARG REPO=https://github.com/Snapchat/KeyDB.git
+ARG BRANCH=main
 RUN set -eux; \
         \
         apk add --no-cache su-exec tini; \
@@ -26,7 +27,7 @@ RUN set -eux; \
                 lz4-dev \
                 snappy-dev \
         ; \
-        cd /tmp && git clone --branch $BRANCH https://github.com/Snapchat/KeyDB.git --recursive; \
+        cd /tmp && git clone --branch $BRANCH $REPO --recursive; \
         cd /tmp/KeyDB; \
         # disable protected mode as it relates to docker
         grep -E '^ *createBoolConfig[(]"protected-mode",.*, *1 *,.*[)],$' ./src/config.cpp; \