Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement wake lock? #412

Open
Myzel394 opened this issue Feb 19, 2022 · 3 comments
Open

Implement wake lock? #412

Myzel394 opened this issue Feb 19, 2022 · 3 comments

Comments

@Myzel394
Copy link

Like this comment already suggested, it would be a great idea to add wake lock to avoid a smartphone go out due to inactivity.

I can implement this feature and propose a PR, is this okay @RobinLinus ?
@hello-smile6
Copy link
Contributor

Like this comment already suggested, it would be a great idea to add wake lock to avoid a smartphone go out due to inactivity.

I can implement this feature and propose a PR, is this okay @RobinLinus ?

It would also be nice for laptops.

@Myzel394 Myzel394 mentioned this issue Feb 20, 2022
Closed
@Bellisario
Copy link
Contributor

Bellisario commented Feb 20, 2022 •
edited
Loading

Like this comment already suggested, it would be a great idea to add wake lock to avoid a smartphone go out due to inactivity.

I can implement this feature and propose a PR, is this okay @RobinLinus ?

Very good idea, @Myzel394, but if you look here, it doesn't seem to work with iOS devices.
But there is another library called NoSleep.js that works perfect with all devices, with a fallback for iOS...

Myzel394 added a commit to Myzel394/snapdrop that referenced this issue Feb 20, 2022
@Myzel394
removed wakeLock in favor of noSleep (SnapDrop#412 (comment))
6121b95
@Myzel394
Copy link
Author

Thank you @Bellisario ! Updated the pull request

schlagmichdoch added a commit to schlagmichdoch/PairDrop that referenced this issue Jan 17, 2023
@schlagmichdoch
implemented NoSleep.js as suggested in this issue: SnapDrop/snapdrop#412
168d10a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add wake-lock Myzel394/snapdrop
3 participants
@Myzel394 @Bellisario @hello-smile6