Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed build when running with coverage on stable Rust #717

Open
tgross35 opened this issue Apr 26, 2024 · 1 comment
Open

Failed build when running with coverage on stable Rust #717

tgross35 opened this issue Apr 26, 2024 · 1 comment

Comments

@tgross35
Copy link

Both wayland-backend and wayland-client have a line like the following:

#![cfg_attr(coverage, feature(coverage_attribute))]

This is a problem because if building a project with coverage will always try to enable this feature, which will fail if using a stable rustc. This should be changed so the coverage_attribute feature and coverage(...) attributes to go with it are not enabled unless compiled with nightly.

I think the easiest fix is probably to add a Cargo feature gate for nightly features and use it in place of #[cfg_attr(coverage, coverage(...))], as well as updating the spots where the feature is enabled.

Lurk added a commit to Lurk/clink that referenced this issue May 15, 2024
Lurk added a commit to Lurk/clink that referenced this issue May 15, 2024
* find_and_replace refactoring
* add condition before adding query params
* use String instead of Rc<str>
* remove unnecessary to_string conversions
* use iterators with strings to simplify the logic
* packages update
* version bump
* try to gather coverage on nightly due to Smithay/wayland-rs#717
@uglyoldbob
Copy link

I would also like to see this implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants