Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy esp8266 toolchain support #2794

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Jun 10, 2024

This PR removes legacy toolchain cruft from the framwork.

  • Old esp8266 libc support not required. All esp-quick-toolchain compiler versions use newlib.
  • Change compiler version check to error. Code won't work with old toolchains.
  • Remove use of GCC_VERSION_COMPATIBLE from UPnP library. Framework does check, libaries don't need to.

@mikee47 mikee47 changed the title Remove legacy toolchains Remove legacy esp8266 toolchains Jun 10, 2024
@mikee47 mikee47 changed the title Remove legacy esp8266 toolchains Remove legacy esp8266 toolchain support Jun 10, 2024
Copy link

what-the-diff bot commented Jun 10, 2024

PR Summary

  • Added Flag for Patched GDB
    An additional flag titled GDBSTUB_GDB_PATCHED was inserted into APP_CFLAGS. This aids in the debugging process with a more sophisticated set of capabilities.

  • Inclusion of Extra Libraries
    The variable EXTRA_LIBS in Sming/Arch/Esp8266/Components/libc/component.mk has been adjusted to include stdc++. This inclusion expands the codebase with added functionalities available in the stdc++ library.

  • Removal of Redundant Files
    Several non-essential files, namely, libmicroc.a, libmicrogcc.a, and libsetjmp.a, have been removed from the Components/libc/lib directory, aiding in decluttering the project repository.

  • File Rename for Better Clarity
    The file libc_replacements.c previously under the newlib directory, has been renamed and relocated directly under the src directory, making it simple to locate.

  • Elimination of Outdated Files
    Five outdated files, namely under the oldlib directory have been deleted - README.rst, pgmspace.c, strcspn.c, strerror.c, and strspn.c. This step would decrease unnecessary elements from the codebase.

  • Version Compatibility Check
    The GCC_VERSION_COMPATIBLE variable in Sming/build.mk has been adjusted to accommodate potential changes in the version of GCC being used.

  • Improved Repository Fetch
    The fetch command in Linux's getting started documentation has been enhanced to include the URL of the Sming repository for straightforward clone operations.

@mikee47 mikee47 force-pushed the fix/remove-legacy-toolchains branch from 55ea26e to cca270e Compare June 10, 2024 10:05
@slaff slaff merged commit 759b89a into SmingHub:develop Jun 10, 2024
38 checks passed
@mikee47 mikee47 deleted the fix/remove-legacy-toolchains branch June 10, 2024 15:22
@slaff slaff mentioned this pull request Jul 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants