-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix client Websockets (broken) #2749
Commits on Mar 29, 2024
-
Ensure
WebsocketConnection::send
releases source stream on failuremikee47 committedMar 29, 2024 Configuration menu - View commit details
-
Copy full SHA for 2268dc0 - Browse repository at this point
Copy the full SHA 2268dc0View commit details -
mikee47 committed
Mar 29, 2024 Configuration menu - View commit details
-
Copy full SHA for c1a5643 - Browse repository at this point
Copy the full SHA c1a5643View commit details
Commits on Mar 31, 2024
-
Update Websocket_Client and add debug tools
Add `wsserver` build target with simple echo server Use local server by default (remote website no longer exists) Add `test.py` script to check connection protocol Update sample to send both text and binary messages
mikee47 committedMar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 705d56a - Browse repository at this point
Copy the full SHA 705d56aView commit details -
Message
Streams without known size are not supported
when closing c……onnection
mikee47 committedMar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 1ece779 - Browse repository at this point
Copy the full SHA 1ece779View commit details -
XorOutputStream needs to take copy of provided mask data
Websocket client passes local mask data which can get corrupted, leading to unreliable messages.
mikee47 committedMar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 91331b7 - Browse repository at this point
Copy the full SHA 91331b7View commit details -
Fix Websocket client key generation
mikee47 committedMar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 2ff3313 - Browse repository at this point
Copy the full SHA 2ff3313View commit details -
Send status code on close, and allow more time before closing connection
mikee47 committedMar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 1adc98a - Browse repository at this point
Copy the full SHA 1adc98aView commit details -
mikee47 committed
Mar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for b728a99 - Browse repository at this point
Copy the full SHA b728a99View commit details -
mikee47 committed
Mar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 8970ce2 - Browse repository at this point
Copy the full SHA 8970ce2View commit details -
mikee47 committed
Mar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for bdae2bd - Browse repository at this point
Copy the full SHA bdae2bdView commit details -
More robust
WebsocketConnection
initialisation to account for conne……ction == nullptr
mikee47 committedMar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 172702f - Browse repository at this point
Copy the full SHA 172702fView commit details -
WebsocketConnection not getting destroyed
HttpConnection is NOT auto-self-destruct so we need to change that during closure.
mikee47 committedMar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 64e3a3d - Browse repository at this point
Copy the full SHA 64e3a3dView commit details -
`HttpClientConnection` resets our `receive` delegate
mikee47 committedMar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for aa03cd6 - Browse repository at this point
Copy the full SHA aa03cd6View commit details -
Don't handle CLOSE message until it's all been processed
mikee47 committedMar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for ef7613d - Browse repository at this point
Copy the full SHA ef7613dView commit details -
mikee47 committed
Mar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 46e8ff9 - Browse repository at this point
Copy the full SHA 46e8ff9View commit details -
Must always send a CLOSE message
Can either be in response to a received CLOSE, or as an outgoing notification. Only difference is in the status code sent.
mikee47 committedMar 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 47d7fa2 - Browse repository at this point
Copy the full SHA 47d7fa2View commit details