Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to OtaNetwork Http upgrader #2725

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Improvements to OtaNetwork Http upgrader #2725

merged 3 commits into from
Mar 8, 2024

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Mar 7, 2024 •
edited
Loading

This PR addresses issue #2724.

  • Queue only one OTA item at a time for download.
  • Only moving to the next one after successful completion.
  • The itemComplete method handles each request directly - updateComplete has been removed.
  • If HttpClient::send (line 43) fails then the relevant stream must be released to avoid a 'double delete' exception.
  • Enable Host support for Basic_Ota sample

@SmingHub SmingHub deleted a comment from what-the-diff bot Mar 7, 2024
@slaff slaff added this to the 5.2.0 milestone Mar 8, 2024
@slaff slaff merged commit 8ba44cb into SmingHub:develop Mar 8, 2024
46 checks passed
@mikee47 mikee47 deleted the fix/http-upgrader branch March 9, 2024 11:21
@slaff slaff mentioned this pull request May 8, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mikee47 @slaff