Moving AtClient to a separate library. #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikee47 I am thinking that maybe AtClient can be completely rewritten to use your IO Control library. |
@slaff Probably a good fit as it's a bit like modbus with a structured command/response. Modems are particularly interesting since they all do a similar job, use AT commands but don't always implement them consistently! This might be accommodated using a basic AT IOControl::device which can be configured with fixed (i.e. flash-based) mappings for various device types. |
mikee47
approved these changes
Mar 31, 2022
Sming/Libraries/AtClient/README.rst
Outdated
| Introduction | ||
| ------------ | ||
|
|
||
| AT commands were initially instructions used to control a modem. AT is the abbreviation of ATtention. Every command line starts with "AT" or "at". |
There was a problem hiding this comment.
Good background article https://en.wikipedia.org/wiki/Hayes_command_set
slaff
force-pushed
the
feature/library-at-client
branch
from
9463964 to
32ea274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a sample (related to #1527).