Host fixes (RTC clock setting, UART restrictions, thread race condition) #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing `setRtcSeconds` breaks applications. Instead, note difference between set time and system time.
Manifests with assertion failure running two telnet ports
Also default UART0 to console, even if other ports are redirected
Options added at command line can be appended to, same as if exported.
mikee47
force-pushed
the
fix/host-updates
branch
from
1f4771d
to
34ef881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting Host RTC clock
Calling
setRtcSeconds()fails which can break applications.Instead, note difference between set time and system time.
UART improvements
Remove Host UART1 TX-only restriction. (Originally included to mirror ESP8266 behaviour.)
Fix race condition in Host threads. Manifests with assertion failure running two telnet ports.
Allow console to be directed to alternative UART. Also default UART0 to console, even if other ports are redirected
CLI_TARGET_OPTIONS
We need a way to more miscellaneous settings from the command line. e.g.
make run CLI_TARGET_OPTIONS=--cpulimit=1.However, currently this means options from
HOST_NETWORK_OPTIONSandHOST_UART_OPTIONSare ignored.This might be considered a bug, so behaviour has been fixed so this works as expected.