Scheme missing from URL in HttpClient_ThingSpeak sample
#1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+LTS |
slaff
pushed a commit
to slaff/Sming
that referenced
this pull request
Nov 5, 2019
slaff
added a commit
that referenced
this pull request
Nov 6, 2019
slaff
pushed a commit
that referenced
this pull request
Jun 23, 2024
This PR addresses some inconsistencies with the `Url` class. **Ensure Url provides default port for default scheme** When building a URL the Scheme defaults to HTTP if not specified. This means the port should also default to 80, but it doesn't. For example: ``` Url url; url.Host = "api.thingspeak.com"; url.Path = "/update"; ``` This produces the correct URL text `http://api.thingspeak.com/update` with the default scheme, but `getPort()` incorrectly returns 0. See #1937 (comment), PR #1945 provided a fix but didn't actually resolve the underlying issue. **Url::toString() doesn't lowercase scheme** For example: ``` Url url; url.Scheme = "HTTP"; url.Host = "api.thingspeak.com"; url.Path = "/update"; ``` Incorrectly produces `HTTP://api.thingspeak.com/update`. **Add `Url::getQueryParameter` method** Care is required when reading query parameters as direct access to the `Query` member variable means non-existent keys get added. Therefore a `const` cast is required. This method provides a more convenient way for safely reading values, and also allows a default to be given where the value doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this port doesn't get set, attempts to connect to port 0 which fails with ERR_ABORT.