Add additional checks to Vector class methods
#1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SmingHub#1618 (comment) * Change `ensureCapacity` to adjust new capacity by `increment`, thus simplifying code which uses it * Add `bool` return value to: `addElement()` - so that `add()` return value isn't meaningless `ensureCapacity()` `setSize()` `insertElementAt()` `setElementAt()`
slaff
reviewed
Jun 12, 2019
Sming/Wiring/WVector.h
Outdated
| ensureCapacity(_capacity + _increment); | ||
| if (_size < _capacity) | ||
| _data[ _size++ ] = new Element(obj); | ||
| if (!ensureCapacity(_size + 1)) return false; |
There was a problem hiding this comment.
Can you please at least put the return on the next line with a bit of offset ? Best would be to use curly braces.
Apply those changes to the other places where you have a return on the same line.
There was a problem hiding this comment.
It would be simplest to just fix all the coding style issues in this file, i.e. just apply the Sming CS and fix all the style issues. The Arduino Esp8266 doesn't use this class (uses std:;vector instead) so it's really a Sming-only file ATM.
mikee47
added a commit
to mikee47/Sming
that referenced
this pull request
Aug 1, 2019
mikee47
added a commit
to mikee47/Sming
that referenced
this pull request
Aug 1, 2019
For example,causes exception when sorting network list in `HttpServer_ConfigNetwork` sample
slaff
pushed a commit
that referenced
this pull request
Aug 1, 2019
mikee47
added a commit
to mikee47/Sming
that referenced
this pull request
Aug 3, 2019
For example,causes exception when sorting network list in `HttpServer_ConfigNetwork` sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1618 (comment)
ensureCapacityto adjust new capacity byincrement, thus simplifying code which uses itboolreturn value to:addElement()- so thatadd()return value isn't meaninglessensureCapacity()setSize()insertElementAt()setElementAt()