Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all core code has standard header and consistent guard naming #1630

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Feb 19, 2019

Comment headers in the following files have been left due to potential license conflict:

SmingCore/Wire.h
SmingCore/twi.h
SmingCore/core_esp82666_si2c.cpp
SmingCore/Wire.cpp
SmingCore/DateTime.cpp
SmingCore/DateTime.h
SmingCore/SPISoft.cpp
SmingCore/SPISoft.h

system/esp-lwip/lwip/*
system/include/espinc/*
system/irq_checks.s
system/xt_interrupts.cpp
system/include/m_printf.h
system/include/m_printf.cpp
system/crash_handler.c
system/esp_cplusplus.cpp
system/uart.cpp

Comment headers in the following files have been left due to potential license conflict:

SmingCore/Wire.h
SmingCore/twi.h
SmingCore/core_esp82666_si2c.cpp
SmingCore/Wire.cpp
SmingCore/DateTime.cpp
SmingCore/DateTime.h
SmingCore/SPISoft.cpp
SmingCore/SPISoft.h

system/esp-lwip/lwip/*
system/include/espinc/*
system/irq_checks.s
system/xt_interrupts.cpp
system/include/m_printf.h
system/include/m_printf.cpp
system/crash_handler.c
system/esp_cplusplus.cpp
system/uart.cpp
@slaff slaff added this to the 3.7.2 milestone Feb 19, 2019
@slaff slaff merged commit 53d422e into SmingHub:develop Feb 19, 2019
@mikee47 mikee47 deleted the fix/comment_headers branch February 19, 2019 11:12
@mikee47
Copy link
Contributor Author

mikee47 commented Feb 19, 2019

Coding style rules updated

@slaff slaff mentioned this pull request Feb 27, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants