General tidy of Netutils module

[mikee47]

Use const qualifier where appropriate
Use unsigned instead of int where appropriate
Replace commented-out code with conditional compilation
Refactor debugPrintTcpList

[mikee47]

debugPrintTcpList() sample output:

24390805 ********** Lwip Active PCB states:
24390953 LWIP_DEBUG: Port 80 | 55613 flg:41 tmr:0025 ESTABLISHED
24391153 LWIP_DEBUG: Port 80 | 55612 flg:40 tmr:0025 ESTABLISHED
24391335 ********** Lwip Listen PCB states:
24391455 LWIP_DEBUG: Port 80 | 0 flg:38 tmr:0000 LISTEN
24391611 ********** Lwip TIME-WAIT PCB states:
24391733 LWIP_DEBUG: Port 80 | 55611 flg:70 tmr:0001 TIME_WAIT
24391905 LWIP_DEBUG: Port 80 | 55610 flg:70 tmr:0001 TIME_WAIT

[slaff]

Since FIX_NETWORK_ROUTING is not defined by default the current behaviour will be changed, right? Or I am missing something?

[mikee47]

Should be the same - see previous implemention of FixNetworkRouting() function (should be fixNetworkRouting()?) All commented out and just returned true.

I haven't dug into the purpose of this at all - if it was only required for an old version of LWIP then can probably just delete it.

[slaff]

Ok, the current change looks good then.

[slaff]

@mikee47 Do you want to fix those issues: https://app.codacy.com/app/slaff2/SmingOfficial/commit?cid=320437732#newIssuesView ?

Showing 1 file with new issues 
Sming/SmingCore/Network/NetUtils.cpp
Checking if unsigned variable 'startPos' is less than zero.
90
if(startPos < 0) {
Checking if unsigned variable 'cur' is less than zero.
95
if(cur < 0) {

[mikee47]

@slaff My bad, fixed. How com Codacy didn't pick this up before merge?