Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Memory Leak in Mqtt #1273

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Conversation

frankdownunder
Copy link
Contributor

Added missing memory deallocations. Only exhibits the memory leak when your connection fails and constantly reties to connect.

@frankdownunder
Copy link
Contributor Author

@slaff My first Pull Request ever, and it failed. Did I do it incorrectly?

@slaff slaff added this to the 3.4.0 milestone Nov 1, 2017
@slaff slaff merged commit 932af74 into SmingHub:develop Nov 1, 2017
@slaff
Copy link
Contributor

slaff commented Nov 1, 2017

@frankdownunder Welcome to the contributors :)

Did I do it incorrectly?

As far as I can see everything is fine. We would be glad to see other PRs from you.

@frankdownunder frankdownunder deleted the MemoryLeakInMqtt branch November 1, 2017 11:02
slaff pushed a commit to slaff/Sming that referenced this pull request Nov 6, 2017
…ith Arduino.

- Arduino compatibility improvements (SmingHub#1213).
- Library code for some Arduino libraries comes directly from their source repositories (Adafruit_ST7735, Adafruit_SSD1306).
- Added dynamic recalculation of image offsets to prevent rom overlapping (SmingHub#1208).
- Added Wi-Fi Protected Setup (WPS) support (SmingHub#1199).
- Ram savings in axTLS (SmingHub#1255).
- Simplified and improved Http Client and Http Server stream handling (SmingHub#1247).
- Fixed Memory Leak in Mqtt (SmingHub#1273).
- Updated Spiffs code to version 0.3.7 + fixes (#SmingHub#1246).

And much more. All merged PRs in this release can be seen from [here](https://github.com/SmingHub/Sming/milestone/12?closed=1)

- Changed the order of Wire.begin and Wire.pins parameters to match the Arduino order (SmingHub#1193).

For a complete list of changes run the following command:

```
git log 3.3.0..3.4.0
```

Thanks to everyone who helped us make this release happen.
mschader pushed a commit to mschader/Sming that referenced this pull request Nov 8, 2017
johndoe8967 added a commit to johndoe8967/Sming that referenced this pull request Dec 18, 2017
* commit 'f8f675415c36dd4d8da45cfc3669f50469c65d8d':
  Preparation for release 3.5.0. (SmingHub#1295)
  Added Stream::indexOf(char c) that finds a character in a stream (SmingHub#1290)
  Made spiffs_mount() compatible with rBoot. (SmingHub#1292)
  Added experimental support for SDK 2.1 (SmingHub#1264)
  Initial test code for improved sendPing and sendPong. (SmingHub#1270)
  Added experimental support for LWIP v2 (SmingHub#1289)
  Fixed ssl memory leaks related to SSL context not being freed (SmingHub#1288)
  Fixed an error breaking SSL session resumption, Http Connection reuse and Http pipelining. (SmingHub#1287)
  Added Adafruit_BME280 Library (SmingHub#1286)
  Allow immediate server deletion if there are no active connections. (SmingHub#1285)
  Deleting an HttpClient should result in freeing the total memory it uses.
  Allow shutting down of TcpServers (SmingHub#1284)
  TcpConnection fixes related to ssl extensions. Styling fixes for HttpClient.
  fix/MemoryLeak(Heap) during TCP Client connection and delete
  Reverted: m_printf: stacksize reduced SmingHub#1097. (SmingHub#1279)
  Preparation for release 3.4.0. (SmingHub#1277)
  Mqtt memory fix: Fix copy and paste error (SmingHub#1276)
  Fix Memory Leak in Mqtt (SmingHub#1273)
  Changed a TcpClient message to be less confusing. (SmingHub#1271)
johndoe8967 added a commit to johndoe8967/Sming that referenced this pull request Jan 16, 2019
* commit '4a0fec18235521e4369d111f111c2624fbd3203b': (50 commits)
  Added the Arduino Libraries.
  Added the latest changes to the third-party projects.
  Preparation for release 3.5.0. (SmingHub#1295)
  Added Stream::indexOf(char c) that finds a character in a stream (SmingHub#1290)
  Made spiffs_mount() compatible with rBoot. (SmingHub#1292)
  Added experimental support for SDK 2.1 (SmingHub#1264)
  Initial test code for improved sendPing and sendPong. (SmingHub#1270)
  Added experimental support for LWIP v2 (SmingHub#1289)
  Fixed ssl memory leaks related to SSL context not being freed (SmingHub#1288)
  Fixed an error breaking SSL session resumption, Http Connection reuse and Http pipelining. (SmingHub#1287)
  Added Adafruit_BME280 Library (SmingHub#1286)
  Allow immediate server deletion if there are no active connections. (SmingHub#1285)
  Deleting an HttpClient should result in freeing the total memory it uses.
  Allow shutting down of TcpServers (SmingHub#1284)
  TcpConnection fixes related to ssl extensions. Styling fixes for HttpClient.
  fix/MemoryLeak(Heap) during TCP Client connection and delete
  Reverted: m_printf: stacksize reduced SmingHub#1097. (SmingHub#1279)
  Preparation for release 3.4.0. (SmingHub#1277)
  Mqtt memory fix: Fix copy and paste error (SmingHub#1276)
  Fix Memory Leak in Mqtt (SmingHub#1273)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants