Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes before the final 3.3.0 #1203

Merged
merged 3 commits into from
Jul 26, 2017
Merged

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Jul 26, 2017

  • ugly fix for systems that don't have GNU find installed by default (example: Windows)
  • small fix for passing by reference of the SSL fingerprint and key-certificate pair.

@slaff slaff added this to the 3.3.0 milestone Jul 26, 2017
@slaff slaff merged commit a789c20 into SmingHub:develop Jul 26, 2017
slaff added a commit to slaff/Sming that referenced this pull request Jul 26, 2017
* Pass the fingerprints and certification pairs by reference.
* Replace the external GNU find with GNU makefile standard functions: dir, wildcard and sort.
@kwis2
Copy link

kwis2 commented Jul 26, 2017

Technical question
I am wondering why there is a lot of problems with Sming compile. I think I found one reason. Sming work with third-party modules, sometimes not newest ones. With master branch there are proper modules included with Sming, while with develop branches modules are linked to git (current) versions.
Would it be possible to include proper modules with all branches?

@slaff
Copy link
Contributor Author

slaff commented Jul 26, 2017

while with develop branches modules are linked to git (current) versions.

@kwis2 Not really. It think that was explained multiple times but will explain it one more time.

  1. When you clone the develop branch you must NOT clone it recursively.
cd <dev-folder>
git clone https://github.com/SmingHub/Sming.git
export SMING_HOME=<dev-folder>/Sming # if you use Windows then: set %SMING_HOME%=<dev-folder->\Sming
  1. When you want to compile the code the build system will take care to get the needed version of the third-party module. The only thing that needs to be done is to type
cd $SMING_HOME
make

If you manually update some of the git-submodules then it is your own fault. If git is difficult for you then work only with the master branch where the third-party modules are fetched and batched for you. And, of course, if you use the master branch you will get updates only when there is a new version. Take today for example :)

@kwis2
Copy link

kwis2 commented Jul 26, 2017

@slaff let me explain. With windows the only way I am able to make Sming to work is to download zip file. In all master branch there are files in third-pary folder, while in develop versions third-party folder is empty and I have to git clone.
Additionally check git third-party folders. With master branch there are files, while in develop there are git links

This way new version 3.3.0 you have commited compile without third-party problem

johndoe8967 added a commit to johndoe8967/Sming that referenced this pull request Jul 28, 2017
* commit '93340e19a1e1e68885a36976113bc400eb2be985': (35 commits)
  Preparation for the final 3.3.0 release. (SmingHub#1202)
  Small fixes before the final 3.3.0 (SmingHub#1203)
  Updated the third-party modules.
  Added example demonstrating Js and CSS combining ... (SmingHub#1200)
  Fixed WebSocket sample HTML page (SmingHub#1201)
  Feature/auto deployment on release (SmingHub#1198)
  Handle incomplete frame to prevent WebsocketClient ending in an endless loop (SmingHub#1189)
  Fixes for styling issues reported by Codacy (SmingHub#1196)
  Feature/httpserver etag caching (SmingHub#1194)
  HttpServer tuning to allow serving of more requests. (SmingHub#1187)
  decode-stacktrace.py: Added python3 compatability. (SmingHub#1190)
  Release Candidate 1 for version 3.3.0. (SmingHub#1185)
  Station::waitConnection method was deprecated and is now removed. (SmingHub#1171)
  Adding fixes for issues reported by Vera++ and CppCheck. (SmingHub#1178)
  Changes related to POST parameter unescaping. (SmingHub#1177)
  Small fixes to comparison and memory related issues. (SmingHub#1172)
  Reset response and request data after completion.
  Custom PWM is enabled by default. (SmingHub#1164)
  TemplateStream: the total length should be calculated from the browser. HttpServer: The default keepalive time is set to 0.
  HttpClient: memory usage fixes. (SmingHub#1161)
  ...
johndoe8967 added a commit to johndoe8967/Sming that referenced this pull request Aug 5, 2017
* commit '855933d10fe88fee52399930f80fa0362c2180a5':
  Added WifiStation.connect() to Basic_rboot sample (SmingHub#1215)
  Appvoyer CI will use the updated choco packages. (SmingHub#1210)
  Added dynamic recalculation of image offsets to prever rom overlapping. (SmingHub#1208)
  Added Gitter Notifications. (SmingHub#1205)
  Better Arduino compatability: Changed to order of the Wire.begin and Wire.pins parameters to (SmingHub#1193)
  Small fixes before the final 3.3.0 (SmingHub#1203)
  Preparation for the final 3.3.0 release. (SmingHub#1202)
  Added example demonstrating Js and CSS combining ... (SmingHub#1200)
  Fixed WebSocket sample HTML page (SmingHub#1201)
  Feature/auto deployment on release (SmingHub#1198)
@slaff slaff deleted the fix/before-3.3.0 branch July 22, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants