Mqtt queued messages not freed when client destroyed (#1594)

SmingHub · Feb 5, 2019 · b344b6a · b344b6a
1 parent 324e808
commit b344b6a
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/Sming/SmingCore/Network/MqttClient.cpp b/Sming/SmingCore/Network/MqttClient.cpp
@@ -59,15 +59,9 @@ MqttClient::MqttClient(bool withDefaultPayloadParser /* = true */, bool autoDest
 
 MqttClient::~MqttClient()
 {
-	mqtt_message_t* message = nullptr;
-	do {
-		message = requestQueue.dequeue();
-		if(message) {
-			break;
-		}
-
-		mqtt_message_clear(message, 1);
-	} while(true);
+	while(requestQueue.count() != 0) {
+		mqtt_message_clear(requestQueue.dequeue(), 1);
+	}
 
 	mqtt_message_clear(&connectMessage, 0);
 	if(outgoingMessage) {