Fix codacy advisories, deprecate HttpRequest copy operator

SmingHub · Feb 18, 2019 · 11ddb12 · 11ddb12
1 parent e856500
commit 11ddb12
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/Sming/SmingCore/Network/Http/HttpHeaders.h b/Sming/SmingCore/Network/Http/HttpHeaders.h
@@ -90,9 +90,18 @@ enum HttpHeaderFieldName {
  *
  *  @todo add name and/or value escaping
  */
-class HttpHeaders : private HashMap<HttpHeaderFieldName, String>
+class HttpHeaders : protected HashMap<HttpHeaderFieldName, String>
 {
 public:
+	HttpHeaders()
+	{
+	}
+
+	HttpHeaders(const HttpHeaders& headers)
+	{
+		*this = headers;
+	}
+
 	String toString(HttpHeaderFieldName name) const;
 
 	/** @brief Produce a string for output in the HTTP header, with line ending

diff --git a/Sming/SmingCore/Network/Http/HttpRequest.cpp b/Sming/SmingCore/Network/Http/HttpRequest.cpp
@@ -17,7 +17,6 @@
 
 HttpRequest::HttpRequest(const HttpRequest& value) : uri(value.uri), method(value.method), headers(value.headers)
 {
-	*this = value;
 	headersCompletedDelegate = value.headersCompletedDelegate;
 	requestBodyDelegate = value.requestBodyDelegate;
 	requestCompletedDelegate = value.requestCompletedDelegate;

diff --git a/Sming/SmingCore/Network/Http/HttpRequest.h b/Sming/SmingCore/Network/Http/HttpRequest.h
@@ -56,6 +56,7 @@ class HttpRequest
 		return new HttpRequest(*this);
 	}
 
+	/** @deprecated Please use `clone()` instead */
 	HttpRequest& operator=(const HttpRequest& rhs) SMING_DEPRECATED;
 
 	~HttpRequest()