Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one fix #682
Main problem is due to the fact that "special_price" is not selected in autocomplete. I thought
addPriceData()
would do this, but it's not the case.The only reason the same bug is not appearing on catalog listing is that special_price is set to
used_in_product_listing=1
and get automatically loaded by the layer.I did not want to load all attributes
used_in_product_listing=1
in the autocomplete (for performances concern, however, this would have fixed the issue easily), so I added only 'special_price' to the list of default selected attributes.I intentionally omitted to add "special_from_date" and "special_to_date".
This is due to the fact that they are used only with Magento CE and this could cause errors when these attributes are missing (if they were deleted, or when using Magento EE).
To allow proper handling of the special price when using these attributes, one will have to add them manually via DI like this :
Let me know if this solution is acceptable for you, or if we should do it another way ?