New smashing website using Jekyll #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvinciguerra
changed the title
terraboops
requested changes
Jun 24, 2018
_includes/header.html
Outdated
| <h1> | ||
| <img src="{{ '/assets/images/smashing-home-text.svg' | prepend: site.url }}" alt="Smashing" width="100%" | ||
| /> | ||
| <small>Sinatra based framework that lets you<br> build excellent dashboards</small> |
There was a problem hiding this comment.
The line-height of this small is all mucked up on my browser, the text runs together. Could be fixed if we make this small into a span and change the h1 to and h2.
There was a problem hiding this comment.
Great... I will fix it! Thanks. :)
There was a problem hiding this comment.
Changed line-height and text element.
Screenshot using Safari Browser and I tested at Firefox too.
|
Awesome! Thanks! |
|
Any time! :) |
|
Well done, looks amazing! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.