Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert axios to CommonJS-only version #226

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

rossiam
Copy link
Contributor

@rossiam rossiam commented Oct 23, 2023

Revert axios to CommonJS-only version. The newer combined ESM/CommonJS version confuses the pkg tool used to build the CLI binary.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • I have read the CONTRIBUTING document
  • My code follows the code style of this project (npm run lint produces no warnings/errors)

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

🦋 Changeset detected

Latest commit: 36a4941

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@smartthings/core-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rossiam rossiam merged commit d9f90a0 into SmartThingsCommunity:main Oct 23, 2023
5 checks passed
@rossiam rossiam deleted the old-axios branch October 23, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants