Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICP-11333] Everspring Radiator Thermostat - fix for timeout after setting mode #34601

Merged
merged 1 commit into from
Jun 24, 2020
Merged

[ICP-11333] Everspring Radiator Thermostat - fix for timeout after setting mode #34601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devicetypes/smartthings/zwave-radiator-thermostat.src/zwave-radiator-thermostat.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def setThermostatMode(String mode) {

[
secure(zwave.thermostatModeV2.thermostatModeSet(mode: modeValue)),
"delay 2000",
"delay 5000",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to make this to a device specific, I'd let @greens weigh in on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've thought about that, but other device doesn't even support thermostat mode (it's hidden with different metadata).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the other device is hiding it anyway I don't mind. I'll wait to merge until Cert confirms they had the same success you did. We've had issues with timing-sensitive changes like this in the past.

secure(zwave.thermostatModeV2.thermostatModeGet())
]
}
Expand Down