CHAD-4340 Update Window Shade devices to use Window Shade Level #30151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpmanley
reviewed
May 4, 2020
devicetypes/smartthings/springs-window-fashions-shade.src/springs-window-fashions-shade.groovy
Show resolved
Hide resolved
tpmanley
reviewed
May 4, 2020
devicetypes/smartthings/springs-window-fashions-shade.src/springs-window-fashions-shade.groovy
Outdated
Show resolved
Hide resolved
tpmanley
reviewed
May 4, 2020
devicetypes/smartthings/zwave-window-shade.src/zwave-window-shade.groovy
Show resolved
Hide resolved
tpmanley
reviewed
Jun 1, 2020
tpmanley
reviewed
Jun 8, 2020
| return result | ||
| def result = null | ||
|
|
||
| if (device.currentValue("shadeLevel") == null) { |
There was a problem hiding this comment.
Might want to also make sure device.currentValue("level") isn't null
tpmanley
reviewed
Jul 21, 2020
| def i = value as Integer | ||
| sendEvent(name:"level", value: value, displayed:true) | ||
|
|
||
| sendEvent(name:"level", value: value, unit:"%", displayed:true) |
There was a problem hiding this comment.
Should we change displayed to false here so it doesn't look like duplicate events in history?
tpmanley
reviewed
Jul 21, 2020
|
|
||
| command "stop" | ||
|
|
||
| capability "Switch Level" // Leaving for second phase for Window Shade Level rollout |
There was a problem hiding this comment.
I don't think we can actually remove this capability ever so I'd just move it up to the main list of capabilities
tpmanley
reviewed
Jul 21, 2020
| if (lastLevel == "undefined" || currentLevel == lastLevel) { //Ignore invalid reports | ||
| log.debug "Ignore invalid reports" | ||
| } else { | ||
| sendEvent(name: "shadeLevel", value: currentLevel) | ||
| sendEvent(name: "level", value: currentLevel) |
There was a problem hiding this comment.
I think we may want to force displayed false here so it only shows shadeLevel in history
tpmanley
reviewed
Jul 21, 2020
| if (lastLevel == "undefined" || currentLevel == lastLevel) { //Ignore invalid reports | ||
| log.debug "Ignore invalid reports" | ||
| } else { | ||
| sendEvent(name: "shadeLevel", value: currentLevel) | ||
| sendEvent(name: "level", value: currentLevel) |
There was a problem hiding this comment.
displayed: false here too
tpmanley
reviewed
Jul 21, 2020
devicetypes/smartthings/zwave-window-shade.src/zwave-window-shade.groovy
Show resolved
Hide resolved
|
@tpmanley Brought in master and made you suggested changes. The Axis handler has some messy logic that my OCD wants me to clean up, but it would be significant enough that I am not going to touch it (besides doing a few smaller changes). |
|
@dkirker I suggest you do a rebase and squash on the latest mater, remove the WIP label and then I'll do a final review |
greens
reviewed
Jul 27, 2020
Comment on lines
347
to
348
| def shadeLevelMap = map.findAll { it.key != "displayed" } | ||
| shadeLevelMap.name = "shadeLevel" |
There was a problem hiding this comment.
I'm very confused about what's going on here, can you explain @dkirker ?
There was a problem hiding this comment.
This is just creating a shadeLevel event if parseReportAttributeMessage returned a level event, but excluding the displayed property (as we don't want to force it to false).
There was a problem hiding this comment.
why not just map.remove("displayed")?
There was a problem hiding this comment.
That'd probably work, too. However, I just opted to go with something even more simpler.
tpmanley
approved these changes
Jul 30, 2020
greens
reviewed
Jul 30, 2020
| def i = value as Integer | ||
| sendEvent(name:"level", value: value, displayed:true) | ||
|
|
||
| sendEvent(name:"level", value: value, unit:"%", displayed: false) |
There was a problem hiding this comment.
is the unit necessary here? we don't have it anywhere else we use switch level afaik
There was a problem hiding this comment.
The unit is defaulted to %. I'm preferring to be pedantic with the use of units.
greens
reviewed
Jul 30, 2020
| @@ -41,14 +42,17 @@ metadata { | |||
| } | |||
|
|
|||
| tiles(scale: 2) { | |||
| multiAttributeTile(name:"windowShade", type: "generic", width: 6, height: 4) { | |||
| multiAttributeTile(name:"windowShade", type: "lighting", width: 6, height: 4) { | |||
There was a problem hiding this comment.
not that it matters since this is classic, but doesn't this put in a lightbulb icon?
There was a problem hiding this comment.
It should use the icons defined in the attributeState definitions.
|
I'll look to merge this after the deploy tomorrow. I'd like to give a little more time before it gets to production. |
greens
approved these changes
Aug 3, 2020
|
k, I'll ping you after the deploy is done |
greens
added a commit
to greens/SmartThingsPublic
that referenced
this pull request
Aug 18, 2020
…el (SmartThingsCommunity#30151)" This reverts commit 878f39a.
TPMhouse
added a commit
to TPMhouse/SmartThingsPublic
that referenced
this pull request
Oct 20, 2020
* Sinope WWST DTH update (SmartThingsCommunity#31140) * Sinope WWST DTH update @shrakuma There's an update following the file that your team shared with us: Sinope_issues_list_update_28_04_2020.xlsx --closed due to fingerprint unwanted modification * Modifying 'Sinope WWST DTH update' Co-authored-by: Vincent G. Beauregrad <[email protected]> * Revert "SmartSense Motion Sensor: Use same icon as catalog for ST sensors" This reverts commit 768a1fc. * ICP-12803 Add three-axis capability to multi sensor metadata (SmartThingsCommunity#32909) * SmartSense Motion Sensor: Use same icon as catalog for ST sensors The catalog has two entries for SmartThings motion sensors. One entry for the newest sensor and second entry for all the other sensors. The second entry uses a different motion sensor icon so we need to specify UI Metadata that also uses that same icon. https://smartthings.atlassian.net/browse/ONEAPP-27569 * WWST-6729 Added fingerprint for Inovelli Dimmer LZW31-SN (SmartThingsCommunity#33531) * Zigbee RGBW Bulb: Add fingerprint for sengled E1F-N5E (SmartThingsCommunity#33597) * ONEAPP-21574 Update device icon for Samjin SmartThings SmartPower Outlet (SmartThingsCommunity#32868) * ONEAPP-21574 Update device icon for Samjin SmartThings SmartPower Outlet * ONEAPP-21573 Update icons for SmartThings moisture sensors (SmartThingsCommunity#33681) * [DevWS] Fingerprint for iTec Home Switch (SmartThingsCommunity#33592) * [DevWS] Add sengled light fingerprint (SmartThingsCommunity#33598) * [DevWS] Add Sengled outlet fingerprint (SmartThingsCommunity#33596) * [WWST-5069,ICP-12456] Added FP and integrated Everspring SP815 and fixed and added parameter for Evesrping SP817 (SmartThingsCommunity#32967) * Added FP and integrated Everspring SP815 and fixed and added parameter for Everspring SP817 Co-authored-by: Zuzanna Wozniak/Home IoT Development (IoT) /SRPOL/Engineer/Samsung Electronics <[email protected]> * ICP-13231- removed cause of duplicated events (SmartThingsCommunity#32782) * ICP-13231 removed cause of duplicated events * moved adding child devices to configure function * Moved creating child events to after adding a child * ICP-12945, ICP-13000 - fix for handling Danfoss Ally battery reports (voltage reports) * [WWST-6790] Fingerprints for DAWON devices (SmartThingsCommunity#33933) * Fingerprints for DAWON devices * Removed redundant else if statement * [CHAD-3909] SmartSense Multi Sensor: Add preference translations (SmartThingsCommunity#33923) * [WWST-6785] Fingerprint for DAWON DNS In-Wall Outlet PM-C140-ZB (SmartThingsCommunity#34249) * ICP-12945, ICP-13000 - fix no 2 for handling Danfoss Ally battery reports (voltage reports) * Added metadata for Sinope Load Controller (SmartThingsCommunity#34454) Co-authored-by: Zuzanna Wozniak/Home IoT Development (IoT) /SRPOL/Engineer/Samsung Electronics <[email protected]> * CHAD-3909 Garage door strings were not set/translated correctly. (SmartThingsCommunity#34614) * [ICP-12852] Added capability 'Temperature Alarm' (SmartThingsCommunity#29024) * Removed 'temperatureAlarm' attribute and changed values in the tiles * Fix for sending 'temperatureAlarm - cleared' event * Added suggested changes in the updated() * Added suggested changes in updated method * Added checking if cleared alarm is not already set while forcing cleared event * Fix Co-authored-by: Zuzanna Wozniak/Home IoT Development (IoT) /SRPOL/Engineer/Samsung Electronics <[email protected]> * WWST-2441, WWST-2448, WWST-2449, WWST-6168, WWST-6171, WWST-6172 - Custom DTH for Qubino Dimmers (DIN, Flush, Flush 0-10V) (SmartThingsCommunity#28554) * New DTH for Qubino Flush Dimmer 0-10V - ZMNHVD * Add associations with groups:5,6 * Shortened list of device settings * Reversed synchronization of device settings * Add a child illuminance sensor * Handle events coming from different types of inputs. Code refactoring. * Shortened list of device settings (removed settings of minimum/maximum dimming value) * WWST-2441, WWST-2448, WWST-2449, WWST-6168, WWST-6171, WWST-6172 - Custom DTH for Qubino Dimmers (DIN, Flush, Flush 0-10V) * removed child illuminance sensor * Fixes * Fixes * Fixes and workarounds, added two missed device preferences. * Fixes * Removed "boolRange" preferences boilerplate code * Fixes, corrected few options' names (for consistency sake) * even devices in different namespaces cannot share names (SmartThingsCommunity#34989) * Fixes for ICP-13200, ICP-13202 (SmartThingsCommunity#34851) * Fixes for setting device preferences properly. Removed unnecessary calls of meterGet. * Removed boolRange boilerplate code. * Fixes for setting device preferences properly.Removed boolRange boilerplate code. * Fixes for setting device preferences properly. * Fix of spacing * ICP-12967 Configure Aeotec Water Sensor to send non-MC reports to preserve local execution (SmartThingsCommunity#34615) * CWD Smart Dimmer Lamp Brand name：CollingWood App：zhangfangwen's smart app device type：bulb relevant information： manufacturer: "CWD" deviceJoinName: "CWD light" * CWD Smart Colour Tuneable Lamp Brand name：CollingWood App：zhangfangwen's smart app device type：bulb relevant information： manufacturer: "CWD" deviceJoinName: "CWD light" * CWD Smart RGBW Lamp Brand name：CollingWood App：zhangfangwen's smart app device type：bulb relevant information： manufacturer: "CWD" deviceJoinName: "CWD light" * [ICP-11333] Extended delay time between set and get thermostat modes commands (SmartThingsCommunity#34601) * [ICP-13020] EZMultipli - fix for timeouts after color change (SmartThingsCommunity#34180) * Fix for timeouts after color change * Added piece of code which prevents inifnite loops * CHAD-3909 Set garage sensor preference to empty string (SmartThingsCommunity#35341) This will be coupled with a future plugin change to add a call to action as part of the ui element. * Revert "Revert "CHAD-3849 Update SmartWeather Station Tile to support the new mobile client"" (SmartThingsCommunity#27246) * Revert "Revert "CHAD-3849 Update SmartWeather Station Tile to support the new mobile client"" * Update custom capability names * Update zigbee-rgbw-bulb.groovy Removed duplicated fingerprints, added missing fingerprint. * Update zigbee-dimmer.groovy Updated to current code from master branch. Removed duplicated fingerprints. * Update zigbee-dimmer.groovy Updated to current code from master branch. Removed duplicated fingerprints. * Update zigbee-dimmer.groovy Updated to current code from master branch. Removed duplicated fingerprints. * Update zigbee-dimmer.groovy Updated to current code from master branch. Removed duplicated fingerprints. * Update zigbee-white-color-temperature-bulb.groovy Updated to current code from master branch. Removed duplicated fingerprints. * Update zigbee-white-color-temperature-bulb.groovy Updated to current code from master branch. Removed duplicated fingerprints. * Update zigbee-white-color-temperature-bulb.groovy Updated to current code from master branch. Removed duplicated fingerprints. * DevWs for CoolKit Technology Co.,Ltd containing containing ZigBee Switch (SmartThingsCommunity#35589) Co-authored-by: 啦啦 王 <[email protected]> * [ICP-13163] Add alarm methods to child, expose chime sounds (SmartThingsCommunity#34995) * Add alarm method to child, expose chime sounds * Space fix, remove if-statements * Fixes * Fixes * fixes build (SmartThingsCommunity#35920) * Changed deviceJoinName: Ultra Thin Wafer -> Wafer * [WWST-2444] New DTH for Qubino Flush 2 Relay (SmartThingsCommunity#34355) * New DTH for Qubino Flush 2 Relay * Added temperature sensor to DTH and removed not used boilerplate * fixup! Added temperature sensor to DTH and removed not used boilerplate * Quick refactoring temperature sensor child device initialization * Renamed temperature sensor's DTH * Removed offlinePingable flag, changed zwaveEvent method call * WWST-6827 - Leviton 4 Speed Fan Controller (SmartThingsCommunity#35590) * Added fingerprint and 4-speed device handling * Added method for getting max supported speeds * Added mnmn and vid, other fixes * Method name, redundant conditional statement - fixes * WWST-6841, WWST-6837 Add two Schlage locks (SmartThingsCommunity#36081) * WWST-6935 Fingerprints for Aoetec Door Window Sensor 7 Pro (SmartThingsCommunity#36264) * [WWST-6921] New DTH Z-Wave Water/Temp/Humidity Sensor (SmartThingsCommunity#36265) * New DTH Z-Wave Water/Temp/Humidity Sensor * Added generic metadata for whole DTH, improved code readability * WWST-6822 Leviton Tamper Resistant Outlet ZW15R (SmartThingsCommunity#35995) * Fingerprint for Leviton Outlet ZW15R * Changed dth * Spacing * ICP-13040 Change zigbee devices to report decimal temperature (SmartThingsCommunity#36278) This accompanies hubcore and appengine-zigbee changes to allow the parsing and reporting of temperature values as floats. * ICP-13330 new UI Metadata for Qubino Temperature Sensor (SmartThingsCommunity#36801) * ICP-13368 Specified metadata for Sinope TH1500ZB (SmartThingsCommunity#36733) * [ICP-13365] Added Tamper Alert for Aeotec Door/Window Sensor 7 Pro (SmartThingsCommunity#36732) * Added Tamper Alert for Aeotec Door/Window Sensor 7 Pro * Actual tamper reports handler * Added initial tamper event * ICP-11324 - new UI Metadata for Sylvania LIGHTIFY Edge-lit flushmount (SmartThingsCommunity#36894) * Fixed 'parseAduroSmartButtonMessage' function in zigbee-mulit-button.groovy (SmartThingsCommunity#36892) Fixed 'parseAduroSmartButtonMessage' function in zigbee-mulit-button.groovy file, the bug that there will be multiple events when pressing a button. other file not change, only want merge zigbee-mulit-button.groovy . Co-authored-by: Andy Yi <[email protected]> * ICP-12929 Standardize how Fibaro preference default text is created (SmartThingsCommunity#36909) * ICP-12929 Standardize how Fibaro preference default text is created There was an existing pattern to to print the enum value of a preference rather than the raw enum, so I've just adopted it across all the fibaro DTHs that were using the incorrect method. * fixup * [WWST-6165] New DTH for Qubino Flush Shutter (SmartThingsCommunity#36082) * New DTH for Qubino Flush Shutter * Deleted Switch Level capability, changed refresh() method, reworded preferences descriptions * Removed unnecessary import statement, added child switch multilevel DTH * CHAD-5256 Update child DNIs when the parent rejoins (SmartThingsCommunity#36908) * CHAD-5256 Update child DNIs when the parent rejoins * [ICP-8763] Zigbee Metering Plug: Prevent duplicate switch events (SmartThingsCommunity#36353) Zigbee Metering Plug: Prevent duplicate switch events * issue fix : ICP-12604: Supported temperature values for the following options. (SmartThingsCommunity#35327) @shrakuma ICP-12604: Supported temperature values for the following options. - Ambient limit - 5-36 degrees in Celsius, or 41-96 degrees in Fahrenheit. - Floor high limit - 5-36 degrees in Celsius, or 41-96 degrees in Fahrenheit. - Floor low limit - 5-36 degrees in Celsius, or 41-96 degrees in Fahrenheit. In the ST application, we can enter from 5-96 (from 5 degrees Celsius to 96 degrees Fahrenheit) → this is confusing. Sinope thermostats support Celsius and Fahrenheit unit systems - this option can be changed manually on the device. Co-authored-by: Vincent G. Beauregrad <[email protected]> * Fingerprint for Ajax Online RGBCCT (SmartThingsCommunity#37167) * DevWs for CoolKit Technology Co.,Ltd containing containing ZigBee Multi Switch (SmartThingsCommunity#37787) * DevWs for CoolKit Technology Co.,Ltd containing containing ZigBee Multi Switch * Update zigbee-multi-switch.groovy Updated comments with "Raw Description" * Update zigbee-multi-switch.groovy Fix of spacing Co-authored-by: 啦啦 王 <[email protected]> Co-authored-by: Konrad K <[email protected]> * DevWs for CoolKit Technology Co.,Ltd containing containing ZigBee Switch (SmartThingsCommunity#35158) Co-authored-by: 啦啦 王 <[email protected]> * ICP-13140 For IKEA blinds return the current state of the blinds when pause is called if the blinds are not moving (SmartThingsCommunity#38018) * ICP-13140 For IKEA blinds return the current state of the blinds when pause is called if the blinds are not moving * Always send pause command over Zigbee * Fix "display" -> "displayed" in sendEvent * CHAD-5172 Send follow-ups to verify that window shade level changes o… (SmartThingsCommunity#36279) * CHAD-5172 Send follow-ups to verify that window shade level changes occurred We noticed what seems to be a device bug when window shades send us unsolicited battery reports at the same time they are told to open/close. This seems to cause them to send us immediate position updates rather than waiting until the action is completed. This change should send periodic gets until we see the value we want, up to 5 times, or about 25s after the intial command. * fixup * logic changes * guarantee overwrite * state variables do not work with += operator * add a +/- 2 range for the level * spacing fix and re-arrange logic * CHAD-5280 Cap number of battery queries (SmartThingsCommunity#37869) * CHAD-5280 Cap number of battery queries Locks will query for battery state after a battery replace event, but in some cases, the lock will go offline before responding resulting in an infinite loop of querying the battery, which can clog the z-wave message queue. * state variables do not work with += operator * this should break any existing devices out of the loop * fixup * [WWST-2446_2447] Add Qubino Relay 1/1D to existing DTH (SmartThingsCommunity#37124) * Add Qubino Relay 1/1D to existing DTH * [ICP-13246] Stelpro Thermostats preferences changes (SmartThingsCommunity#32881) * Changes to Stelpro preferences * fixup! Changes to Stelpro preferences * Copied 'secondsPast' method from another DTH. * Switched back to old logic, with new preference description and events time inverval * Forcing to show every changig current state event * Revert "Forcing to show every changig current state event" This reverts commit 7077e0e. * Minor fixes * Comment change * [ICP-13322, ICP-13326, ICP-13336, ICP-13345, ICP-13346, ICP-13355] - fixes for Qubino Dimmers (SmartThingsCommunity#37228) * fixes: ICP-13322, ICP-13326, ICP-13355 * fixes2: ICP-13322, ICP-13326, ICP-13355 * fixes3: ICP-13322, ICP-13326, ICP-13355 * fix for ICP-13345 - add meterGet commands * Fix for adding elements to commands collection * ICP-13336 - Removed option 3, because it does not apply to Qubino Temperature Sensor ZMNHEA1. * Added fingerprint for Ajax Online Filament Bulb (SmartThingsCommunity#38132) * CHAD-5256 Hotfix to update child DNIs of zigbee-multi-switch (SmartThingsCommunity#38146) * CHAD-5256 change re-addressing code There was more code using the leading 0 of child devices than I first noticed, so the leading zero in the child DNI has simply been re-added. * adds a fix for devices that were migrated while this bug was active. * add code to avoid a bug encountered if installed and updated are called in succession * ICP-13392 Added fingerprints of device with updated firmware alongside one configuration command (SmartThingsCommunity#38227) * 'displayed' flag set to false for configuration event (SmartThingsCommunity#21920) * [WWST-6159] Qubino Flush Shutter DC - fingerprint and improvements (SmartThingsCommunity#38295) * Added fingerprint for Qubino Flush Shutter DC * Opening/closing report also for manual actions * [ICP-13423] Qubino Flush 2 Relay - Added initial poll (SmartThingsCommunity#38316) * WWST-6946 Somfy Glydea Ultra fingerprint (SmartThingsCommunity#38386) * DevWS add fingerprint for Ecolink DWZB1-ECO door/window sensor (SmartThingsCommunity#38312) * ICP-12883,ICP-12849, ICP-12851 - Add mnmn and VID to: Dome DMMS1 and NEO Coolcam Motion Light Sensor fingerprints (SmartThingsCommunity#30195) * ICP-12883 - added mnmn and VID to Dome Motion/Light Sensor DMMS1 fingerprint * ICP-12883 - Device specific VID in Dome Motion/Light Sensor DMMS1 fingerprint * ICP-12849, ICP-12851 - Add mnmn and a device specific VID to NEO Coolcam Motion/Light Sensor fingerprints * ICP-10928 - Zigbee RGBW Bulb: Fix color temperature value on initial join, code refactoring. (SmartThingsCommunity#30421) Set the color temperature to 5000K on initial join. 5000K was chosen because it is one of the values that is doesn't change when converted to mireds and back again and because it is in the supported range of all the devices that have fingerprints in this DTH. The code was also refactored to make more use of the Zigbee library. * Handled values for energy and power events * WWST-6286 Added fingerprint and some tweaks for Aeotec Radiator Thermostat (SmartThingsCommunity#38798) * CHAD-5336 Make sure that temperature offset calculations for Zigbee devices are correct and rounded to one decimal (SmartThingsCommunity#38946) * SmartPower Outlet: Fix icon for the outletv4 https://smartthings.atlassian.net/browse/ONEAPP-31381 * ICP-13200 - longer delay between BasicSet and BasicGet commands (SmartThingsCommunity#38875) * Add fingerprint for CST thermostat Honeywell T6 Pro (SmartThingsCommunity#39100) * CHAD-5355 Zigbee lock event de-duplication (SmartThingsCommunity#39101) * Uses logic similar to what we do in z-wave locks to delay events created from lock attribute reports in case we receive a much more detailed operation event later. If the operation event is sent first, the lock attribute event will be marked as not displayed. * always delay lock attribute reports * add log message * fixup * fixup * WWST-6984,WWST-6989,WWST-6994 Fingerprints for Dawon Power Manager Smart Switches (US) (SmartThingsCommunity#39724) Co-authored-by: Zuzanna Wozniak/Home IoT Development (IoT) /SRPOL/Engineer/Samsung Electronics <[email protected]> * CHAD-4340 Update Window Shade devices to use Window Shade Level (SmartThingsCommunity#30151) * update parseAduroSmartButtonMessage function (SmartThingsCommunity#40488) Some customers reported that the buttons 1 and 4 are not sensitive, so restore the zigbee.ONOFF_CLUSTER event trigger of button 1 and button 4, which will increase the success rate of event reporting after the button is pressed Co-authored-by: Andy Yi <[email protected]> * [ICP-13162] Add alarm event when tamper is triggered (SmartThingsCommunity#36895) * Add alarm event when tamper is triggered * Add off event * Fixes * Change time in runIn method, add chime off event * Revert "CHAD-4340 Update Window Shade devices to use Window Shade Level (SmartThingsCommunity#30151)" This reverts commit 878f39a. * WWST-7064 - Fingerprint for Innr EU Smart Plug SP 220 * WWST-7065 - Fingerprint for Innr Smart Color Bulb E26 AE 280 C * WWST-7066, WWST-7067, WWST-7068 - Fingerprints for Innr Smart Outdoor Flex Light 2m Colour OFL 120 C, Innr Smart Outdoor Flex Light 4m Colour OFL 140 C, Innr Smart Outdoor Spot Light Colour OSL 130 C * [ICP-13444] Delete child switches on Flush Relay 1/1D (SmartThingsCommunity#40329) * Delete child switches on Flush Relay 1/1D * Aeon hem gen5 association fix and Configuration update (SmartThingsCommunity#40990) * Resolve association issue and updated Parameters Resolved association Group 1 association to Node ID 01, ensures HEM Gen5 is properly associated - Line 142 (delete node association) - Line 143 (reassign SmartThings to Association Group 1) Parameter settings (Line 162 - 167) to report kWh and Watt total every 300 seconds. Selective reporting disabled - Param 101 = 3 - Param 102 = 0 - Param 103 = 0 - Param 111 = 300 - Param 90 = 0 - Param 13 = 0 * Change definition name back to default Line 20 * [ICP-13278] Added preferences for Aeotec Nano Dimmer to adjusting the dimmer level (SmartThingsCommunity#37125) * Added preferences for Aeotec Nano Dimmer to adjusting the dimmer level * Added requested changes * Changed name of the method * Fix * Updated the description of the needed preference and removed unnecessary one * Fix Co-authored-by: Zuzanna Wozniak/Home IoT Development (IoT) /SRPOL/Engineer/Samsung Electronics <[email protected]> * [ICP-13555] EZEX power meter patch. (SmartThingsCommunity#41807) [ICP-13555] EZEX power meter patch. * [ICP-13555] EZEX power meter patch SmartThingsCommunity#2. [ICP-13555] EZEX power meter patch SmartThingsCommunity#2. * Somfy Sonesse fingerprint * [WWST-6729] DTH for Inovelli Dimmer LZW31-SN (SmartThingsCommunity#37229) * Added fingerprint for Inovelli Dimmer LZW31-SN * WWST-6729 Added mcd dth for Inovelli Dimmer LZW31-SN * removed old reference to Inovelli Dimmer * Changed child dth name, fixed formatting, removed unnecessary capabilities, fixed child dni * Added configure method, fixed parameters range, fixed formatting * Removed unecessary parameters * Deleted LED Bar color preference from settings view, shortened delay between commands * Level event is created on every level change * Deleted minHubCoreVersion added mnmn * Added child buttons * Changed button event from up/down to pushed, button labels and supported values. Deleted unnecessary code. * Fixed energy rounding * ICP-11574 - query device for current status in response to WakeUpNotification (SmartThingsCommunity#42036) * ICP-11574 - query device for current status in response to WakeUpNotification * WWST-6725 Added fingerprint for Inovelli Dimmer LZW31 (SmartThingsCommunity#42221) * CHAD-5236 CHAD-5235 Add translation strings for Fibaro Smoke & Z-Wave Siren (SmartThingsCommunity#42146) * CHAD-5236 Add translation strings for Z-Wave Siren * CHAD-5235 Add translation strings for Fibaro Smoke Sensor * update in response to testing and verification * DevWs for Ajaxonline Ltd containing containing ZigBee RGBW Bulb (SmartThingsCommunity#42713) * DevWs for Ajaxonline Ltd containing containing ZigBee RGBW Bulb * Update zigbee-rgbw-bulb.groovy I fixed spacing (4 spaces -> 1 tab) Co-authored-by: Konrad K <[email protected]> * ONEAPP-33322 Update range for tempOffset preference * ICP-11574 - Query device for current status in response to WakeUpNotification (SmartThingsCommunity#42710) * WWST-5667_2 - check if device is SOMFY, code refactoring. (SmartThingsCommunity#42726) * CHAD-5235 Hotfix en-uk is not a valid language code. this was due to manual editing on my part * CHAD-5235 CHAD-5236 Spot fixes for translations Programmatic default values are overwritten by "Tap to set" in DM if they have not yet been set and "tap to set" is not translated. Fixes missing period that was preventing the application of translations. * [WWST-4667] Qubino 3 Phase Meter integration (SmartThingsCommunity#43205) * New DTHes to support Qubino 3 Phase Meter * Added raw description, changed child device DTH other minor fixes * ICP-13360 Qubino Dimmer: Addded querying the device about meter values in basic report handling (SmartThingsCommunity#42729) * [WWST-6748] Fingerprint for Yale Fingerprint Lock YMF40 (SmartThingsCommunity#43641) * C2C-1064 Update Ecobee notify text * CHAD-5382 Prepare Z-Wave Battery Thermostat for Local Execution (SmartThingsCommunity#43642) * CHAD-5382 Prepare Z-Wave Battery Thermostat for Local Execution Adds the Humidity Measurement capability that was being populated but not declared Sets the hubcore version required for local thermostat execution. Removes unused "currentSetpoint" attribute that was cruft from battery-less DTH * [ICP-13584; ICP-13551] Fingerprint change for Somfy Glydea, pause() method tweak (SmartThingsCommunity#43795) * WWST-6945 - support for Somfy Situo 4 Zigbee Pure (SmartThingsCommunity#43628) * WWST-6945 - support for Somfy Situo 4 Zigbee Pure * [ICP-13278] Changed minimum dimmer level range in settings for Aeotec Nano Dimmer (SmartThingsCommunity#43964) Co-authored-by: Zuzanna Wozniak/Home IoT Development (IoT) /SRPOL/Engineer/Samsung Electronics <[email protected]> * update smartsense-motion-sensor.groovy (SmartThingsCommunity#44143) update smartsense-motion-sensor.groovy,Optimize that deviceJoinName，change the vid to generic-motion-2 Co-authored-by: Andy Yi <[email protected]> * ICP-11574 Manually set smoke alarm wakeup interval to 4 hours (SmartThingsCommunity#44128) * ICP-11574 Manually set smoke alarm wakeup interval to 4 hours * don't set wakeupinterval for first alert, since there is legacy behavior * Z-Wave Basic Window Shade fix + Calibration (SmartThingsCommunity#44034) * Z-Wave Basic Window Shade fix + Calibration - Open() and Close() buttons resolved - Calibration Parameter setting included in preference * Fix of requested issues - Return pair name to "Aeotec Window Treatment" - Fixed spacing of lines 61 - 73 - Removed else block on line 171 * Fixed Requested issues - Fixed indentation to use tabs. (line 165) - Fixed range instead of the use of text. (line 69) * Update Part 3 - Nano Shutter - used calibrationTime rather than int Time. (Line 164) - Condensed preference input for "calibrationTime" - Added note on top of calibrationTime to indicate it is specific to Nano Shutter and the function its used in. * Update Nano Shutter Part 4 - Added case "open": on line 117 case "close": on line 121 * DevWs for CoolKit Technology Co.,Ltd containing containing ZigBee Switch (SmartThingsCommunity#41408) Co-authored-by: 啦啦 王 <[email protected]> * ONEAPP-33321 Update Korean translations (SmartThingsCommunity#44467) * ICP-13664, ICP-13665 Deleted old fingerprint for Inovelli Dimmer LZW31-SN (SmartThingsCommunity#45024) * WWST-7022 Added fingerprint for POPP Strike Lock Control (SmartThingsCommunity#45045) * [CHAD-5501][zigbee multi switch] Need Exception handling for eZEX multi switch (SmartThingsCommunity#44306) * Exception handling for eZEX * Change the logic * ICP-13694 - removes supporting the Battery capability (SmartThingsCommunity#45566) * ICP-13694 - removes supporting the Battery capability * ICP-13694 - removes supporting the Battery capability * reverts innr fingerprint (SmartThingsCommunity#45829) * CHAD-5290 Move Schlage BR469ZP fingerprint (SmartThingsCommunity#45988) Because this device reports door lock operation events prior to notification events, lock code events are generated without the necessary user code data. This was causing user-code based automations to not fire. Since this device executes locally, it would have required a high-risk fix in hubcore. Rather than removing the device entirely, we are moving it to a DTH where user codes would not be accessible for the purposes of creating automations. * ICP-13566/ICP-13565 Change metadata for Qubino 1D (SmartThingsCommunity#45982) * [WWST-6516] New DTHes to cover Fibaro Walli Roller Shutter functionality (SmartThingsCommunity#30258) * New DTHes to cover Fibaro Walli Roller Shutter functionality * Added Child Venetian Blind DTH and changed namespace * Further fixes for bugs discovered during work with similar device * Ongoing work Fibaro Walli Roller Shutter * Added Window Shade Level capability * [ICP-13618] Qubino Flush 2 Relay - energy usage is not reported (SmartThingsCommunity#43446) * Added daily energy usage report * Changes in getEnergyUsage method * Moved to querying energy usage after power report * C2C-1027 Ecobee Capability Migration in Groovy integration Adding discrete thermostat capabilities to prepare migration to st-schema integration * CHAD-5488 Update Keen Home Smart Vent (SmartThingsCommunity#45127) * CHAD-5488 Update Keen Home Smart Vent includes a workaround for a bug introduced in newer vent FWs adds the draft atmospheric pressure measurement capability instead of custom attributes if the vent detects it is obstructed, it will attempt to clear its obstruction automatically * update obstruction detection * fixes and update to obstruction detection * fixup * rework configuration flow * fixup * remove obstruction handling * CHAD-5555 Update z-wave device multichannel to work in oneapp (SmartThingsCommunity#46568) * CHAD-5555 Update z-wave device multichannel to work in oneapp Because of its variable number of components, the child devices cannot be added as components. * add updated method to convert legacy implementations * Recessed Door Sensor 7 device type update (SmartThingsCommunity#46572) * Update def configure() Lines 136 - 140 - configure Recessed Door Sensor 7 upon pairing to enable Binary Sensor Report - fixes issue where Open/Close status does not update when paired using S2 Authentication * Update state check Line 137 changed to zwaveInfo.mfr == "0371" && zwaveInfo.model == "00BB" * DevWs for DAWON DNS containing containing Zigbee Metering Plug and 2 more (SmartThingsCommunity#43376) * DevWs for DAWON DNS containing containing Zigbee Metering Plug and 2 more * 1. Changed deviceJoinName(ST Dawon Outlet -> Dawon Outlet). 2. Changed the structure of getEnergyDiv(). 3. Added isDawonOutlet() . * re-coding * Changed deviceJoinName. * re-coding * Changed deviceJoinName * original Public DTH * add * master DTH * Update zigbee-metering-plug.groovy Add Dawon Outlet * Update zigbee-switch.groovy remove empty line * Update zigbee-multi-switch.groovy remove empty line * Update zigbee-metering-plug.groovy remove command "reset" * Update zigbee-metering-plug.groovy remove empty line * Update zigbee-switch.groovy remove empty line * Update zigbee-switch.groovy * Update zigbee-metering-plug.groovy remove reset Co-authored-by: 남수 허 <[email protected]> * WWST-6752 Fingerprint for Yale Fingerprint Lock YDF40 (SmartThingsCommunity#43948) * ICP-13708 Added proper fingerprint for Yale YMF40 (SmartThingsCommunity#46734) * DevWs for DAWON DNS containing containing Zigbee Metering Plug and 2 more (SmartThingsCommunity#43376) * DevWs for DAWON DNS containing containing Zigbee Metering Plug and 2 more * 1. Changed deviceJoinName(ST Dawon Outlet -> Dawon Outlet). 2. Changed the structure of getEnergyDiv(). 3. Added isDawonOutlet() . * re-coding * Changed deviceJoinName. * re-coding * Changed deviceJoinName * original Public DTH * add * master DTH * Update zigbee-metering-plug.groovy Add Dawon Outlet * Update zigbee-switch.groovy remove empty line * Update zigbee-multi-switch.groovy remove empty line * Update zigbee-metering-plug.groovy remove command "reset" * Update zigbee-metering-plug.groovy remove empty line * Update zigbee-switch.groovy remove empty line * Update zigbee-switch.groovy * Update zigbee-metering-plug.groovy remove reset Co-authored-by: 남수 허 <[email protected]> * ICP-12798 Update Doorbell Siren 6 to support Sound/Volume control (SmartThingsCommunity#44305) * Update aeotec-doorbell-siren-6.groovy - Added setting/preference option to configure volume/sound via Multichannel Cmd Encap (Sound Switch Configuration SET) * Update code format Format fixes - zwave command classes use hex values for their input - device preferences and def variables changed to have initial lowercase letters - open braces are now on same line as if statements - closing braces are now on the same line as following else statements - fixed minor formatting issues Code change - separated multichannel encap as mcEncap() and encap() to handle Multichannel Cmd Encap (Sound Switch Configuration Set) separately * Quick update Remove 0x79: 1 from secureencapsulation and encapsulation. * Condense private mcEncap() Condensed code to use response(cmd) for MC Cmd Encap (Sound Switch Config SET). * just a comment edit Non-essential commit, changed commend on line 336 * added return to line 336 - Add return in front of line 336 * Final update for minor changes - Changed steps in description on line 57 for better user flow. * Fixed child device status update - Fixed issue where child devices were not updating. Button press and tamper child devices now change states. - Edited Line 162 -164 to set state.lastTriggeredSound when a new sound is playing from a different endpoint. * CHAD-5552, CHAD-5553, CHAD-5554 Update legacy MCD devices to properly work as MCD (SmartThingsCommunity#47247) * CHAD-5552, CHAD-5553, CHAD-5554 Update legacy MCD devices to properly work as MCD * Logic updates * DevWs for HAB Home Intelligence containing containing iblinds v3 (SmartThingsCommunity#42736) * DevWs for HAB Home Intelligence containing containing iblinds v3 * Bring v3 code in to other DTH and protect with device model check * Remove extra space. Ooops! * Fix exceptions * Add protection against exceptions when configuring Co-authored-by: Eric Barnett <[email protected]> Co-authored-by: Donald Kirker <[email protected]> * ICP-13708 Fixed typo in module name (SmartThingsCommunity#47261) * [ICP-13411] Qubino Flush Shutter - energy usage is not reported (SmartThingsCommunity#42222) * Schedule energy usage poll once a day * Moved to querying energy usage after power report * WWST-7143 - changes deviceJoinName to WAFER. Co-authored-by: Steven Green <[email protected]> Co-authored-by: SmartThings, Inc <[email protected]> Co-authored-by: Vincent G. Beauregrad <[email protected]> Co-authored-by: Tom Manley <[email protected]> Co-authored-by: Donald Kirker <[email protected]> Co-authored-by: MWierzbinskaS <[email protected]> Co-authored-by: sxl1987 <[email protected]> Co-authored-by: iTecHome <[email protected]> Co-authored-by: ZWozniakS <[email protected]> Co-authored-by: Zuzanna Wozniak/Home IoT Development (IoT) /SRPOL/Engineer/Samsung Electronics <[email protected]> Co-authored-by: Konrad Klimczuk <[email protected]> Co-authored-by: PKacprowiczS <[email protected]> Co-authored-by: BJanuszS <[email protected]> Co-authored-by: Konrad K <[email protected]> Co-authored-by: Zhang Fangwen <[email protected]> Co-authored-by: 啦啦 王 <[email protected]> Co-authored-by: MGoralczykS <[email protected]> Co-authored-by: ADUROSMART ERIA <[email protected]> Co-authored-by: Andy Yi <[email protected]> Co-authored-by: jwg-123 <[email protected]> Co-authored-by: Bartlomiej Janusz/Home IoT Development (IoT) /SRPOL/Associate/Samsung Electronics <[email protected]> Co-authored-by: Aeotec-ccheng <[email protected]> Co-authored-by: Juhaki Park <[email protected]> Co-authored-by: Ajax Online <[email protected]> Co-authored-by: Vinay Rao <[email protected]> Co-authored-by: Taejun Park <[email protected]> Co-authored-by: ingvar.marstorp <[email protected]> Co-authored-by: dwd-kwon <[email protected]> Co-authored-by: 남수 허 <[email protected]> Co-authored-by: habhomegit <[email protected]> Co-authored-by: Eric Barnett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window Shade Levelis the preferred capability for Window Shade devices expressing a level value.The first step is to add this capability to the devices which use it. The next step is to look in to considering removing the
Switch Levelcapability. For now we will leave it in the DTH, but remove it from the metadata.Locally executing integrations will need to be considered, too.