-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unlatch command and Unlatched status (Unbolt feature) #1756
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Hunsup Jung <[email protected]>
Duplicate profile check: Warning - duplicate profiles detected. |
Invitation URL: |
Test Results 64 files 401 suites 0s ⏱️ For more details on these failures, see this check. Results for commit b002d61. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against b002d61 |
config: | ||
values: | ||
- key: "lock.value" | ||
enabledValues: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think unlatched
needs to be added to enabledValues
in all these new *-unlatch profiles
@@ -1660,6 +1689,7 @@ local new_matter_lock_handler = { | |||
[capabilities.lock.ID] = { | |||
[capabilities.lock.commands.lock.NAME] = handle_lock, | |||
[capabilities.lock.commands.unlock.NAME] = handle_unlock, | |||
[capabilities.lock.commands.unlatch.NAME] = handle_unlatch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe supportedLockCommands
needs to be set appropriately as well, either including unlatch
or not, depending on whether the device supports the UBOLT feature
Check all that apply
Type of Change
Checklist
Description of Change
To support the Unbolt feature
Summary of Completed Tests