Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unlatch command and Unlatched status (Unbolt feature) #1756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HunsupJung
Copy link
Collaborator

@HunsupJung HunsupJung commented Nov 15, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

To support the Unbolt feature

Summary of Completed Tests

Copy link

Duplicate profile check: Warning - duplicate profiles detected.
lock-unlatch.yml == lock.yml
lock-user-pin-schedule-unlatch.yml == lock-user-pin-schedule.yml
lock-user-pin-unlatch.yml == lock-user-pin.yml
lock-user-schedule-unlatch.yml == lock-user-schedule.yml
lock-user-unlatch.yml == lock-user.yml

Copy link

Copy link

Test Results

   64 files    401 suites   0s ⏱️
1 999 tests 1 996 ✅ 0 💤 3 ❌
3 439 runs  3 435 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit b002d61.

Copy link

File Coverage
All files 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 88%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against b002d61

config:
values:
- key: "lock.value"
enabledValues:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think unlatched needs to be added to enabledValues in all these new *-unlatch profiles

@@ -1660,6 +1689,7 @@ local new_matter_lock_handler = {
[capabilities.lock.ID] = {
[capabilities.lock.commands.lock.NAME] = handle_lock,
[capabilities.lock.commands.unlock.NAME] = handle_unlock,
[capabilities.lock.commands.unlatch.NAME] = handle_unlatch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe supportedLockCommands needs to be set appropriately as well, either including unlatch or not, depending on whether the device supports the UBOLT feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants