Implement Flow Sensor device type #1665
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
Test Results 63 files 397 suites 0s ⏱️ Results for commit 48b7a8a. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 48b7a8a |
hcarter-775
reviewed
Oct 3, 2024
drivers/SmartThings/matter-sensor/src/test/test_matter_flow_sensor.lua
Outdated
Show resolved
Hide resolved
|
we need a fingerprint for the device 👍 |
I forgot to respond but I added one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
CHAD-13850
This change adds support for the Flow Sensor device type. This device type was added to matter spec a while ago but has not been implemented into our platform yet.
This PR shouldn't be merged until the tickets listed on this page are complete.
Summary of Completed Tests
New unit tests were implemented to verify the cluster -> capability mappings. Note that there are not any existing matter flow sensors yet, and there is not a virtual flow sensor device in the VDA, so we can't test this on a real device at this time.