Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doConfigure for RVC #1626

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

HunsupJung
Copy link
Collaborator

@HunsupJung HunsupJung commented Sep 10, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

There's an issue that Dreame RVC is not working.
In detail, Dreame RVC has mandatory clusters RVC RunMode, RVC Operational state cluster but doesn't have RunCleanMode cluster. so we need to map the appropriate profile accoding to the cluster list supported by each device.

https://smartthings.atlassian.net/browse/IOTE-4435

Summary of Completed Tests

Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

Copy link

github-actions bot commented Sep 10, 2024

Test Results

   62 files    384 suites   0s ⏱️
1 864 tests 1 864 ✅ 0 💤 0 ❌
3 267 runs  3 267 ✅ 0 💤 0 ❌

Results for commit 06b6ba9.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 10, 2024

File Coverage
All files 24%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/init.lua 24%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 06b6ba9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant