Update #57
Merged
Update #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't store entries with state 'deleted'. This purges a device completely. Since deCONZ 2.10.4 deCONZ::Node won't be created if neither of these entries exist to prevent reappearance of delted nodes.
Since deCONZ 2.10.4 reappearance of deleted nodes is fixed. Which means that deCONZ::Node is only created under stricter conditions, see #4772 This PR enabled creation of light nodes even if light search isn't running anymore, but minimal required data has already been queried from the device (Node Descriptor and Simple Descriptors). The reason this came up is that in larger installations where >100 devices where joined sucessfully and appeared in the GUI wheren't processed completely and light resources where missing albeit the device was already joined during a Permit Join enabled phase.
Since the --always-add-lights commandline parameter exists this can be enabled if needed without causing confusion.
Move electrical measurement related code to dedicated file
sensor->modelId() iterates over all ResourceItems and dereferences the QString pointer. Since the value is used quite often here it can be cached.
FIX : Create a battery sensor for Tuya Blind AM43
Add initial support for Yoolax Blinds
Add initial support for Tuya TYZB01 light sensor
Electrical measurement: Improve handler performance
Move simple metering related code to dedicated file
Add initial support for Drayton Wiser Radiator Thermostat
Add initial support for Xiaomi Aqara D1 switches QBKG21LM & QBKG22LM
Add initial support for Tuya 3 Button _TZ3000_rrjr1q0u
Calls like sensor->modelId() iterate over all ResourceItem and their descriptors to get the actual item. This PR caches the modelId at the beginning of the function. Most reduntant checks for sensor pointer where removed as well. Further the manufacturerCode from bt.restNode->node()->nodeDescriptor().manufacturerCode() is cached.
Improve lights and sensor deletion
Improve sendConfigureReportingRequest() performance
Streamline attribute reporting config and align polling
Move Xiaomi special reporting related code to dedicated file
"else" was left from refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.