Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REALLY BIG CHANGES (refoldering, jest, tests examples, component-relative images, storybook, logo, nomoresemicolons, ) #125

Closed
wants to merge 28 commits into from

Conversation

srghma
Copy link
Contributor

@srghma srghma commented Aug 20, 2017

related issues:
#93, #97, #106

  1. Not all components/containers have tests, cause I dont need them (there exists some examples #1, #2, but personally I think tests with MockedProvider are flaky, so I am going to hardly use e2e tests and storybook with snapshots, dunno, how you making TTD with graphcool?) (cool backend lib)
  2. schema.graphql again not in lib, @Sly777 you said you foreshadow several schemas, dunno, it looks prettier)) if someone want several schemas - he made it
  3. helper_scripts unchanged)

@Sly777
Copy link
Owner

Sly777 commented Aug 21, 2017

Hey @BjornMelgaard, Sorry but I cannot accept this because It's huge. Really. Also, It has significant changes that you didn't ask or suggest (that means we even didn't talk). Even I cannot merge it because of the conflicts. Sorry but I need to close this. Please split your changes and then we can talk (and I can also review).

@Sly777 Sly777 closed this Aug 21, 2017
@srghma
Copy link
Contributor Author

srghma commented Aug 21, 2017

@Sly777 , ok, what if I move jest and storybook to another branch, and left all other things, can we then discuss it?

@Sly777
Copy link
Owner

Sly777 commented Aug 21, 2017

@BjornMelgaard, You need to split to...; (I created this list after checking the files fastly)

  • Jest
  • Storybook
  • Eslint changes
  • Stylelint
  • Logo
  • Offline-ready changes
  • Theme
  • folder structure
  • Others (if there is)

@Sly777
Copy link
Owner

Sly777 commented Aug 21, 2017

for example;

@srghma
Copy link
Contributor Author

srghma commented Aug 21, 2017

@Sly777, fk, there's a lot work to do, I even would say its impossible, I can split on jest and others, but others are tightly coupled. And I even dont know do you like directory structure (I afraid that changes would be futile).

I glad to see that you like it, I decided to store images in component directory, cause storybook does not find the pictures correctly from /static directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants