Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changelog && revert dependency update #4142

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Conversation

J3fftw1
Copy link
Contributor

@J3fftw1 J3fftw1 commented Feb 24, 2024

Description

Update the changelog
Revert dependency update from maven-shade-plugin from 3.5.2 to 3.5.1. This made it so jitpack couldnt build due to maven-shade-plugin requring Maven version 3.6.3, jitpack runs 3.6.1.

Proposed changes

Update the changelog
Revert dependency update from maven-shade-plugin from 3.5.2 to 3.5.1. This made it so jitpack couldnt build due to maven-shade-plugin requring Maven version 3.6.3, jitpack runs 3.6.1.

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@J3fftw1 J3fftw1 requested a review from a team as a code owner February 24, 2024 18:03
@github-actions github-actions bot added the 🧹 Chores Refactoring / Cleanup. label Feb 24, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

Copy link
Contributor

github-actions bot commented Feb 24, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: de34aa6c

https://preview-builds.walshy.dev/download/Slimefun/4142/de34aa6c

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 25, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Sfiguz7 Sfiguz7 merged commit d528884 into master Feb 25, 2024
15 checks passed
@Sfiguz7 Sfiguz7 deleted the chore/update-changelog branch February 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants