-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add rc warnings to sf versions
command
#4129
base: master
Are you sure you want to change the base?
Conversation
Your Pull Request was automatically labelled as: "🧹 Chores" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4129/26d7b086
|
Where else we can add warning messages? maybe the version in sf guide? |
I think we should re-word this, “we don’t provide support for stable versions” won’t make sense to 99% of people if they don’t know RC is meant for plugin developers. |
src/main/java/io/github/thebusybiscuit/slimefun4/core/commands/subcommands/VersionsCommand.java
Outdated
Show resolved
Hide resolved
on the guide settings for players maybe. Im in general not a huge fan of giving a warning. |
if you don't want such messages I will turn this into a bug fix PR. |
Description
People who use RC versions still report bugs to Discord/GitHub, adding warning messages may possibily stop them from reporting. (just possible, people without eyes will still report)
Also fixed a issue introduced in #4096, where all the text after updater available have hover event.
This will only apply to future RC versions.
Test run (I changed the version manually to RC - 38, and this is only screenshot for first run):
Proposed changes
Add warning messages to
/sf versions
.Related Issues (if applicable)
N/A
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values